diff --git a/src/pyobo/struct/struct.py b/src/pyobo/struct/struct.py index 92c5cba8..29798e9d 100644 --- a/src/pyobo/struct/struct.py +++ b/src/pyobo/struct/struct.py @@ -689,11 +689,11 @@ def from_obonet(cls, graph: nx.MultiDiGraph) -> 'Obo': e.reference = reference raise e xrefs, provenance = [], [] - for reference in node_xrefs: - if reference.prefix in PROVENANCE_PREFIXES: - provenance.append(reference) + for node_xref in node_xrefs: + if node_xref.prefix in PROVENANCE_PREFIXES: + provenance.append(node_xref) else: - xrefs.append(reference) + xrefs.append(node_xref) try: alt_ids = list(iterate_node_alt_ids(data)) diff --git a/tests/test_get.py b/tests/test_get.py index a25a87f9..0cbe8191 100644 --- a/tests/test_get.py +++ b/tests/test_get.py @@ -174,5 +174,6 @@ def test_get_id_alts_mapping(self): alt_id: CHEBI:14384 """ id_alts_mapping = self.obo.get_id_alts_mapping() - self.assertIn('16042', id_alts_mapping) + self.assertNotIn('C00462', id_alts_mapping) + self.assertIn('16042', id_alts_mapping, msg='halide anion alt_id fields not parsed') self.assertEqual({'5605', '14384'}, set(id_alts_mapping['16042']))