Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for perl before loading BioNetGen files #103

Closed
luciansmith opened this issue Feb 25, 2022 · 5 comments
Closed

Check for perl before loading BioNetGen files #103

luciansmith opened this issue Feb 25, 2022 · 5 comments

Comments

@luciansmith
Copy link
Contributor

If perl isn't on the user's system, loading a BioNetGen file will fail with "The system cannot find the file specified". It will appear as if the bionetgen file itself was unable to be found. However, the problem is actually that when BNG initializes itself, it runs a perl command, which thows the FileNotFoundError if perl isn't present. It might be nice to check for the existence of perl before trying to load the file. (As it was, I assumed that the file in question was the bionetgen file, which was not the case.)

@luciansmith luciansmith added the enhancement New feature or request label Feb 25, 2022
@jonrkarr
Copy link
Member

jonrkarr commented Feb 25, 2022

This is really a BioNetGen issue. I recommend posting this to RuleWorld/PyBioNetGen

@luciansmith
Copy link
Contributor Author

Oh, I guess I got the wrong repository; RuleWorld/bionetgen#244 I assume they'll transfer the issue when they get to it.

I don't know how responsive BNG is to this sort of thing, so figured I'd go ahead and post it here as a low-priority enhancement in the meantime.

@jonrkarr
Copy link
Member

I could add this here, but I'd prefer not to assume that PyBioNetGen necessarily relies on Perl since they're moving toward a separate BioNetGen library that won't be implemented with Perl.

Sanan has been fairly responsive to feedback.

@jonrkarr jonrkarr added enhancement to dependency and removed enhancement New feature or request labels Feb 25, 2022
@luciansmith
Copy link
Contributor Author

Fair enough! Let's just go with the filed issue, then, and drop this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants