Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eggshell stucture #29

Open
nilshempelmann opened this issue Dec 2, 2018 · 7 comments
Open

eggshell stucture #29

nilshempelmann opened this issue Dec 2, 2018 · 7 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@nilshempelmann
Copy link
Member

shlould the modules
config.py dependencies.py exceptions.py log.py utils.py be moved to a subpackage eggshell.utils??

@nilshempelmann nilshempelmann self-assigned this Dec 2, 2018
@nilshempelmann nilshempelmann added the help wanted Extra attention is needed label Dec 2, 2018
@cehbrecht
Copy link
Member

I would keep the modules at the current place. A subpackage might be needed if we want to split a module.

@huard
Copy link
Collaborator

huard commented Dec 3, 2018

My suggestion is that if the functions are likely to be used by all birds and do not require heavy dependencies, then we keep them in the top package.

@nilshempelmann
Copy link
Member Author

OK Thanks
So currently it is config.py dependencies.py exceptions.py log.py utils.py at top level.
Than subpackage for

  • nc for netCDF dependencies e.g. ogc_utils.py

  • eo for Earth Observation data handling

  • visual for ploting with e.g. matplotlib and cartopy

  • legacy needs to be cleand out. for look-up purpose. should be deleted soon.

If blackswan is now getting in place, we could add:

  • R for the r-dependencies.

Also should the shapefiles be moved into eggshell may be into a data folder? (#20)

@cehbrecht
Copy link
Member

visual for ploting with e.g. matplotlib and cartopy

is visual the right wording? Maybe just vis as shortcut for visualization, or map, plot, ...?

@nilshempelmann
Copy link
Member Author

agree.
would change into plot wich might be the easiest to understand

@nilshempelmann
Copy link
Member Author

I deleted legacy. All functions can be found in flyingpigeon.v1.3

@cehbrecht
Copy link
Member

I deleted legacy. All functions can be found in flyingpigeon.v1.3

This is probably the better way :) They can also be found in the tagged eggshell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants