Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scikit-learn's mean_squared_error API change breaks MachineControl.fit #38

Open
dkgaraujo opened this issue Mar 7, 2025 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@dkgaraujo
Copy link
Collaborator

mean_squared_error no longer takes argument squared. This is breaking MachineControls.fit, see traceback from re-running file 01_machine_controls.qmd:

> synth_BR.fit(X_pre, y_pre)

---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
File /Users/douglasaraujo/Coding/gingado/0[1](https://file+.vscode-resource.vscode-cdn.net/Users/douglasaraujo/Coding/gingado/01_machine_controls.qmd:1)_machine_controls.qmd:1
----> 1 synth_BR.fit(X_pre, y_pre)

File ~/Coding/gingado/gingado/estimators.py:271, in MachineControl.fit(self, X, y)
    [268](https://file+.vscode-resource.vscode-cdn.net/Users/douglasaraujo/Coding/gingado/~/Coding/gingado/gingado/estimators.py:268) self._select_controls(X=X, y=y)
    [270](https://file+.vscode-resource.vscode-cdn.net/Users/douglasaraujo/Coding/gingado/~/Coding/gingado/gingado/estimators.py:270) if self.with_placebo:
--> [271](https://file+.vscode-resource.vscode-cdn.net/Users/douglasaraujo/Coding/gingado/~/Coding/gingado/gingado/estimators.py:271)     self._fit_placebo_models(X=X, y=y)
    [273](https://file+.vscode-resource.vscode-cdn.net/Users/douglasaraujo/Coding/gingado/~/Coding/gingado/gingado/estimators.py:273) X_donor_pool, y = self._validate_data(X[self.donor_pool_], y)
    [275](https://file+.vscode-resource.vscode-cdn.net/Users/douglasaraujo/Coding/gingado/~/Coding/gingado/gingado/estimators.py:275) self.estimator.fit(X=X_donor_pool, y=y)

File ~/Coding/gingado/gingado/estimators.py:209, in MachineControl._fit_placebo_models(self, X, y)
    [207](https://file+.vscode-resource.vscode-cdn.net/Users/douglasaraujo/Coding/gingado/~/Coding/gingado/gingado/estimators.py:207) self.placebo_models_[entity] = clone(self.estimator)
    [208](https://file+.vscode-resource.vscode-cdn.net/Users/douglasaraujo/Coding/gingado/~/Coding/gingado/gingado/estimators.py:208) self.placebo_models_[entity].fit(X_pl, y_pl)
--> [209](https://file+.vscode-resource.vscode-cdn.net/Users/douglasaraujo/Coding/gingado/~/Coding/gingado/gingado/estimators.py:209) self.placebo_score_pre_[entity] = mean_squared_error(
    [210](https://file+.vscode-resource.vscode-cdn.net/Users/douglasaraujo/Coding/gingado/~/Coding/gingado/gingado/estimators.py:210)     y_true=y_pl, 
    [211](https://file+.vscode-resource.vscode-cdn.net/Users/douglasaraujo/Coding/gingado/~/Coding/gingado/gingado/estimators.py:211)     y_pred=self.placebo_models_[entity].predict(X=X_pl),
    [212](https://file+.vscode-resource.vscode-cdn.net/Users/douglasaraujo/Coding/gingado/~/Coding/gingado/gingado/estimators.py:212)     squared=False
    [213](https://file+.vscode-resource.vscode-cdn.net/Users/douglasaraujo/Coding/gingado/~/Coding/gingado/gingado/estimators.py:213) )

File ~/Coding/.venv_gingado/lib/python3.10/site-packages/sklearn/utils/_param_validation.py:194, in validate_params.<locals>.decorator.<locals>.wrapper(*args, **kwargs)
    [191](https://file+.vscode-resource.vscode-cdn.net/Users/douglasaraujo/Coding/gingado/~/Coding/.venv_gingado/lib/python3.10/site-packages/sklearn/utils/_param_validation.py:191) func_sig = signature(func)
    [193](https://file+.vscode-resource.vscode-cdn.net/Users/douglasaraujo/Coding/gingado/~/Coding/.venv_gingado/lib/python3.10/site-packages/sklearn/utils/_param_validation.py:193) # Map *args/**kwargs to the function signature
--> [194](https://file+.vscode-resource.vscode-cdn.net/Users/douglasaraujo/Coding/gingado/~/Coding/.venv_gingado/lib/python3.10/site-packages/sklearn/utils/_param_validation.py:194) params = func_sig.bind(*args, **kwargs)
    [195](https://file+.vscode-resource.vscode-cdn.net/Users/douglasaraujo/Coding/gingado/~/Coding/.venv_gingado/lib/python3.10/site-packages/sklearn/utils/_param_validation.py:195) params.apply_defaults()
    [197](https://file+.vscode-resource.vscode-cdn.net/Users/douglasaraujo/Coding/gingado/~/Coding/.venv_gingado/lib/python3.10/site-packages/sklearn/utils/_param_validation.py:197) # ignore self/cls and positional/keyword markers

File /Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/inspect.py:3179, in Signature.bind(self, *args, **kwargs)
   [3174](https://file+.vscode-resource.vscode-cdn.net/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/inspect.py:3174) def bind(self, /, *args, **kwargs):
   [3175](https://file+.vscode-resource.vscode-cdn.net/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/inspect.py:3175)     """Get a BoundArguments object, that maps the passed `args`
   [3176](https://file+.vscode-resource.vscode-cdn.net/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/inspect.py:3176)     and `kwargs` to the function's signature.  Raises `TypeError`
   [3177](https://file+.vscode-resource.vscode-cdn.net/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/inspect.py:3177)     if the passed arguments can not be bound.
   [3178](https://file+.vscode-resource.vscode-cdn.net/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/inspect.py:3178)     """
-> [3179](https://file+.vscode-resource.vscode-cdn.net/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/inspect.py:3179)     return self._bind(args, kwargs)

File /Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/inspect.py:3168, in Signature._bind(self, args, kwargs, partial)
   [3166](https://file+.vscode-resource.vscode-cdn.net/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/inspect.py:3166)         arguments[kwargs_param.name] = kwargs
   [3167](https://file+.vscode-resource.vscode-cdn.net/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/inspect.py:3167)     else:
-> [3168](https://file+.vscode-resource.vscode-cdn.net/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/inspect.py:3168)         raise TypeError(
   [3169](https://file+.vscode-resource.vscode-cdn.net/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/inspect.py:3169)             'got an unexpected keyword argument {arg!r}'.format(
   [3170](https://file+.vscode-resource.vscode-cdn.net/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/inspect.py:3170)                 arg=next(iter(kwargs))))
   [3172](https://file+.vscode-resource.vscode-cdn.net/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/inspect.py:3172) return self._bound_arguments_cls(self, arguments)
@dkgaraujo dkgaraujo added the bug Something isn't working label Mar 7, 2025
@dkgaraujo
Copy link
Collaborator Author

@jdamp-bis since you recently reviewed changes ins scikit-learn and how they could affect gingado, could you please check if it's really just an API change as I suspect, and open the PR to fix it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants