Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML parsers for data reading #50

Open
javihern98 opened this issue May 21, 2024 · 13 comments · May be fixed by #59
Open

XML parsers for data reading #50

javihern98 opened this issue May 21, 2024 · 13 comments · May be fixed by #59
Assignees
Milestone

Comments

@javihern98
Copy link
Contributor

  • Add XML parsers for data reading on SDMX-ML 2.1 Generic and Structure Specific
  • Add Pandas optional dependency

Depends on #46

@javihern98 javihern98 self-assigned this May 21, 2024
@javihern98 javihern98 added this to the 1.0 milestone Jun 25, 2024
@javihern98
Copy link
Contributor Author

@sosna @stratosn Please review the membership of @albertohernandez1995, seems he is not allowed to push

@stratosn
Copy link
Collaborator

@javihern98 the invitation to @albertohernandez1995 was sent last Monday, but it is still pending.
@albertohernandez1995 can you check, please?

@albertohernandez1995
Copy link

albertohernandez1995 commented Jun 28, 2024 via email

@stratosn
Copy link
Collaborator

stratosn commented Jun 28, 2024

Hi @albertohernandez1995 can you check here: https://github.com/settings/organizations
The invitation should be there.
If not, we can send a new one.

@javihern98 javihern98 linked a pull request Jul 1, 2024 that will close this issue
@javihern98
Copy link
Contributor Author

Hi @stratosn all good now, thanks!

@javihern98
Copy link
Contributor Author

@sosna @stratosn Would you have somewhere a data file that references a Provision Agreement for testing?

<message:Structure structureID="AAA"
                   namespace="urn:dummy"
                   dimensionAtObservation="AllDimensions">
    <common:ProvisionAgrement>
        ....................................
    </common:ProvisionAgrement>
</message:Structure>

@stratosn
Copy link
Collaborator

stratosn commented Jul 1, 2024

Hi @javihern98, do you need an example on how to reference a Provision Agreement or the actual data file with the related Structures?

@javihern98
Copy link
Contributor Author

javihern98 commented Jul 1, 2024 via email

@stratosn
Copy link
Collaborator

stratosn commented Jul 1, 2024

Ok, then we need to prepare something from scratch, but if you already have a dataset that references a Dataflow, then the changes should not be a lot.

@javihern98
Copy link
Contributor Author

javihern98 commented Jul 1, 2024 via email

@stratosn
Copy link
Collaborator

stratosn commented Jul 1, 2024

Sorry cannot see the file on GH. Maybe you could upload using the UI, or simply send it to me by email.

@javihern98
Copy link
Contributor Author

javihern98 commented Jul 1, 2024

Sorry @stratosn , please find it here (changed externsion to TXT to upload it correctly):

BIS_DER_DATAFLOW.txt

@stratosn
Copy link
Collaborator

stratosn commented Jul 2, 2024

Thanks, @javihern98
This file can easily refer to the Provision Agreement, only by changing the header <message:Structure> content, ie:

        <message:Structure structureID="BIS_WEBSTATS_DER_DATAFLOW_1_0"
                           namespace="urn:sdmx:org.sdmx.infomodel.datastructure.Dataflow=BIS:WEBSTATS_DER_DATAFLOW(1.0):ObsLevelDim:TIME_PERIOD"
                           dimensionAtObservation="AllDimensions">
            <common:ProvisionAgrement>
                <Ref agencyID="BIS" id="WEBSTATS_DER_DATAFLOW_PRA" version="1.0"/>
            </common:ProvisionAgrement>
        </message:Structure>

Note that the 2.1 schemas include a typo (ProvisionAgrement instead of ProvisionAgreement)

Of course, this is the only change directly impacted by the referencing, but if you wanted to make it more meaningful, it might be useful to consider further Constraints.
If you need something more on that, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants