Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Dynup and Walking visualization #298

Open
16stelter opened this issue Jan 21, 2021 · 2 comments · Fixed by #622
Open

Refactor Dynup and Walking visualization #298

16stelter opened this issue Jan 21, 2021 · 2 comments · Fixed by #622
Labels
enhancement New feature or request motion

Comments

@16stelter
Copy link

Describe the solution you'd like

The visualization from Dynup should be moved to a visualizer class. Furthermore the publishArrowMarker class exists in both Dynup and Walking, which is an unneccessary duplicate.
@16stelter 16stelter added the enhancement New feature or request label Jan 21, 2021
@jaagut jaagut transferred this issue from bit-bots/bitbots_motion Jan 23, 2024
@Flova Flova added the motion label Jan 24, 2024
@Flova Flova mentioned this issue Nov 14, 2024
Merged
6 tasks
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Software Nov 28, 2024
@jaagut jaagut reopened this Nov 28, 2024
@github-project-automation github-project-automation bot moved this from ✅ Done to 📋 Backlog in Software Nov 28, 2024
@jaagut
Copy link
Member

jaagut commented Nov 28, 2024

@Flova you wrote in #622, it only partially resolves this issue. Is that still true?

@Flova
Copy link
Member

Flova commented Nov 28, 2024

Yep, we only did the walking, not the dynup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request motion
Projects
Software
Status: 📋 Backlog
Act
Status: Ideas / Nice to have
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Walk_viz cleanup bit-bots/bitbots_main
3 participants
@Flova @16stelter @jaagut