Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCM dies because of not getting the wolfgang_hardware_interface parameters from other node #637

Closed
val-ba opened this issue Dec 13, 2024 · 1 comment · Fixed by #638
Closed
Assignees
Labels
bug Something isn't working

Comments

@val-ba
Copy link
Contributor

val-ba commented Dec 13, 2024

Summary

In #2ee3299 the get_parameters from other node method was added.
In #4037e548d703d0c84e56d84c9f04eb46c18e4fca the motor start delay was added.
Now the HCM dies, because a runtime error occurs when starting the sim script.

Expected behavior

Normal simulator functionality with being able to walk etc.

Current behavior

HCM dies.
There is not /wolfgang_hardware_interface node, because if sim is used the sim parameter is true.
This results in the ros_control.launch not being started which leads to the node in bitbots_ros_control not being started (no wolfgang_hardware_interface node).

Steps to Reproduce

  1. Build on current main.
  2. Run ros2 launch bitbots_bringup simulator_teamplayer.launch game_controller:=false behavior:=false.
  3. Wait 20 seconds.

Possible Solution

  • Use separate parameter for startup not in wolfgang.yaml.
  • Set parameter in launch file
  • Mock wolfgang_hardware_interface node for the parameters if sim:=true
@val-ba val-ba added the bug Something isn't working label Dec 13, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Software Dec 13, 2024
@Flova
Copy link
Member

Flova commented Dec 13, 2024

Ah this is unfortunate, we don't wait the defined duration in the sim, but we still fetch the parameter in the blackboard...

@Flova Flova mentioned this issue Dec 17, 2024
6 tasks
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Software Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants