Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Walk_viz cleanup #622

Merged
merged 10 commits into from
Nov 28, 2024
Merged

Walk_viz cleanup #622

merged 10 commits into from
Nov 28, 2024

Conversation

Flova
Copy link
Member

@Flova Flova commented Nov 14, 2024 •
edited
Loading

Summary

Clean up the walk_vizualizer class and increase it's performance.

Partially closes #298

Checklist

  • Run colcon build
  • Write documentation
  • Test on your machine
  • Test on the robot
  • Create issues for future work
  • Triage this PR and label it

@Flova Flova requested review from SammyRamone and jaagut November 21, 2024 18:37
SammyRamone
SammyRamone approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@SammyRamone SammyRamone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Flova Flova merged commit e11d125 into main Nov 28, 2024
2 checks passed
@Flova Flova deleted the refactor/walk_vizualizer branch November 28, 2024 17:32
@jaagut jaagut mentioned this pull request Nov 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SammyRamone SammyRamone SammyRamone approved these changes

@jaagut jaagut Awaiting requested review from jaagut

Assignees
No one assigned
Labels
None yet
Projects
Software
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor Dynup and Walking visualization
2 participants
@Flova @SammyRamone