-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CODINGCONTRACT: HammingCode: Clarify difference between Wikipedia implementaion and in-game implementaion #1610
Comments
This contract type/pair feels particularly problematic for wording clarity and brevity - I think it's worthy of note that these are the only contracts we link out to external resources on - so thank you for bringing this up.
The wiki article makes references to 'extended Hamming codes' in a few places to explain the purpose of the additional parity bit, but I agree the example in [8,4] Hamming code with an additional parity bit is misleading in that the additional bit is at the "back end" (P2^N rather than P0). Would |
I agree with this more than anything else. Overall I like this coding contract, but knowing what I know now, if I were the one deciding if it should be added I'm not sure I'd say yes. XD |
Not too bad. However, it may not sufficient to mitigate the confusion from wikipedia. I would like to add Another solution could be removing Wikipedia article from description, as other reference ( |
Apologies for taking a while on this. There's a linked PR now, I'd appreciate your thoughts @bupjae (and anyone else!) |
The Coding Contract description for HammingCode mentions wikipedia article as refernece.
However, in-game uses slighty different coding scheme than wikipedia article.
Namely, we add one extra parity bit at the very beginning of binary string, compared to wikipedia article.
It seems that in-game scheme is also used widely as it has its own advantage (i.e. SECDED).
However, for players, they have hard time when their implementaion which follows wikipedia article doesn't work well.
I think clarifying difference on scheme between in-game and wikipedia article will be helpful.
The text was updated successfully, but these errors were encountered: