Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Display RedeemScript or Descriptor Information on HW Screen #224

Open
justinmoon opened this issue Jul 19, 2019 · 4 comments
Open

Comments

@justinmoon
Copy link
Contributor

justinmoon commented Jul 19, 2019

Let's say I have 2/2 multisig. I generate a receiving address on desktop and check it against hwi displayaddress --desc <desc> on both devices. Then I know that each device controls a key in the multisig address.

But how do I actually verify that the address corresponds to a 2/2 multisig address and not k/k where k > 2 without trusting any UI except the hardware wallet display.

Possible attack: the redeemscript is actually 3/3 with 2 of our keys and a 3rd pubkey that belongs to a ransomer.

@justinmoon justinmoon changed the title [Feature] Display redeem script on device [Feature] Display redeemScript Information on HW Screen Jul 19, 2019
@justinmoon justinmoon changed the title [Feature] Display redeemScript Information on HW Screen [Feature] Display RedeemScript or Descriptor Information on HW Screen Jul 19, 2019
@justinmoon
Copy link
Contributor Author

After investigating more, it seems that multisig addresses can't be displayed. Every library display_address function has a Only supports single-key based addresses comment. This would be very nice -- hardware wallet multisig is kinda pointless if you can't verify receiving addresses on device display.

@instagibbs
Copy link
Collaborator

All devices handle this differently, either by imo trusting too much, all the way to requiring the user to register multisig wallets on the device first. Going to be difficult to do without a standard.

@justinmoon
Copy link
Contributor Author

justinmoon commented Aug 29, 2019

What about just displaying a multisig address on device display using the displayaddress HWI command? I know that at least trezor and coldcard can do this in Electrum.

Is this something we could implement here? (I can take a stab at it ...)

@instagibbs
Copy link
Collaborator

That could be a partially-supporting feature yes.

I really want to somehow convince all manufacturers to support registering descriptors so we can have a unified "display address" feature :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants