From fa8ade300f421dcc3b0cd956ab03a50a5ae80646 Mon Sep 17 00:00:00 2001
From: MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>
Date: Fri, 17 Jan 2025 17:49:55 +0100
Subject: [PATCH] refactor: Avoid GCC false positive error
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This avoids an overly agressive GCC false positive warning:

error: ‘tmp’ may be used uninitialized [-Werror=maybe-uninitialized]
---
 src/test/fuzz/float.cpp | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/test/fuzz/float.cpp b/src/test/fuzz/float.cpp
index 6897e814948..c80c4877e6c 100644
--- a/src/test/fuzz/float.cpp
+++ b/src/test/fuzz/float.cpp
@@ -1,4 +1,4 @@
-// Copyright (c) 2020-2021 The Bitcoin Core developers
+// Copyright (c) 2020-present The Bitcoin Core developers
 // Distributed under the MIT software license, see the accompanying
 // file COPYING or http://www.opensource.org/licenses/mit-license.php.
 
@@ -11,6 +11,7 @@
 #include <cassert>
 #include <cmath>
 #include <limits>
+#include <optional>
 
 FUZZ_TARGET(float)
 {
@@ -18,7 +19,7 @@ FUZZ_TARGET(float)
 
     {
         const double d{[&] {
-            double tmp;
+            std::optional<double> tmp;
             CallOneOf(
                 fuzzed_data_provider,
                 // an actual number
@@ -42,7 +43,7 @@ FUZZ_TARGET(float)
                       }); },
                 // Anything from raw memory (also checks that DecodeDouble doesn't crash on any input)
                 [&] { tmp = DecodeDouble(fuzzed_data_provider.ConsumeIntegral<uint64_t>()); });
-            return tmp;
+            return *tmp;
         }()};
         (void)memusage::DynamicUsage(d);