chore: services

Author: reez

BDKSwiftExampleWallet/Service/BDK Service/BDKService.swift

@@ -14,7 +14,7 @@ private class BDKService {
     var network: Network
     private var wallet: Wallet?
     private let keyService: KeyClient
-    private let esploraClient: EsploraClient  // TODO: this is new, and it's use can be refactored in this file
+    private let esploraClient: EsploraClient
     private var needsFullScan: Bool = false
 
     init(
@@ -197,9 +197,6 @@ private class BDKService {
         )
         let _ = try wallet.applyUpdate(update: update)
         let _ = try wallet.commit()
-        // TODO: Do i need to do this next step of setting wallet to wallet again?
-        // prob not
-        self.wallet = wallet
     }
 
     func fullScanWithInspector(inspector: FullScanScriptInspector) async throws {
@@ -214,9 +211,6 @@ private class BDKService {
         )
         let _ = try wallet.applyUpdate(update: update)
         let _ = try wallet.commit()
-        // TODO: Do i need to do this next step of setting wallet to wallet again?
-        // prob not
-        self.wallet = wallet
     }
 
     func calculateFee(tx: Transaction) throws -> UInt64 {

BDKSwiftExampleWallet/Service/Key Service/KeyService.swift

@@ -13,7 +13,7 @@ private struct KeyService {
     private let keychain: Keychain
 
     init() {
-        let keychain = Keychain(service: "com.matthewramsden.bdkswiftexamplewallet.testservice")  // TODO: use `Bundle.main.displayName` or something like com.bdk.swiftwalletexample
+        let keychain = Keychain(service: "com.matthewramsden.bdkswiftexamplewallet.testservice")
             .label(Bundle.main.displayName)
             .synchronizable(false)
             .accessibility(.whenUnlocked)

README.md

@@ -12,7 +12,7 @@ An example iOS app using [Bitcoin Dev Kit](https://github.com/bitcoindevkit) (BD
 
 ### Wallet
 
-Supports single key HD wallets with BIP86 derivation paths. 
+Defaults to single key HD wallets with BIP86 derivation paths. 
 
 ### Implemented