Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSize fails to account for sigops/datacarriercost in many instances #62

Open
11 tasks
luke-jr opened this issue Mar 15, 2024 · 0 comments
Open
11 tasks

Comments

@luke-jr
Copy link
Member

luke-jr commented Mar 15, 2024

In various locations, including the GUI's transaction details dialog and the "vsize" result in many RPC results, transaction virtual sizes may not account for an unusually high number of sigops (ie, as determined by the -bytespersigop policy). This could result in reporting a lower virtual size than is actually used for mempool or mining purposes.

  • Refactor DatacarrierBytes & CalculateExtraTxWeight to use CTxUndo
  • rpc_sign_show_fees
  • TxToUniv "vsize" should be able to use undo data
  • MempoolTxsToJSON: need to generate fake undo data
  • decoderawtransaction: ???
  • decodepsbt: ???
  • TxToJSON/getrawtransaction: should be able to figure out from undo data OR mempool
  • doc & tests: handle vsize possibly being missing (pruned blocks)
  • wallet/gettransaction: should be able to figure out from undo data OR mempool
  • bitcoin-tx/OutputTxJSON: omit vsize & doc???
  • rest_tx: should be able to figure out from undo data OR mempool
@luke-jr luke-jr added the bug label Mar 15, 2024
@luke-jr luke-jr added this to the 27.0 milestone Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant