Fix suggestions suggested by coderabbit review (#321)

Author: praveenperera

rust/crates/cove-util/src/lib.rs

@@ -2,6 +2,8 @@ pub mod encryption;
 pub mod format;
 pub mod result_ext;
 
+pub use result_ext::ResultExt;
+
 use bitcoin::secp256k1::hashes::sha256::Hash as Sha256Hash;
 use std::hash::{DefaultHasher, Hasher as _};
 

rust/crates/cove-util/src/result_ext.rs

@@ -7,7 +7,7 @@ pub trait ResultExt<T, InitialError> {
     /// that takes a String, using the Display implementation of InitialError.
     ///
     /// # Example
-    /// ```
+    /// ```rust
     /// use cove_util::result_ext::ResultExt;
     ///
     /// #[derive(Debug, thiserror::Error)]

rust/src/database/unsigned_transactions.rs

@@ -131,9 +131,7 @@ impl UnsignedTransactionsTable {
     fn get(&self, key: &TxId) -> Result<Option<UnsignedTransactionRecord>, Error> {
         let read_txn = self.db.begin_read().map_err_str(Error::DatabaseAccess)?;
 
-        let table = read_txn
-            .open_table(MAIN_TABLE)
-            .map_err(|error| Error::TableAccess(error.to_string()))?;
+        let table = read_txn.open_table(MAIN_TABLE).map_err_str(Error::TableAccess)?;
 
         let value = table
             .get(key)
@@ -146,9 +144,7 @@ impl UnsignedTransactionsTable {
     fn get_tx_ids_for_wallet_id(&self, key: &WalletId) -> Result<Vec<TxId>, Error> {
         let read_txn = self.db.begin_read().map_err_str(Error::DatabaseAccess)?;
 
-        let table = read_txn
-            .open_table(BY_WALLET_TABLE)
-            .map_err(|error| Error::TableAccess(error.to_string()))?;
+        let table = read_txn.open_table(BY_WALLET_TABLE).map_err_str(Error::TableAccess)?;
 
         let ids = table
             .get(key)

rust/src/file_handler.rs

@@ -17,7 +17,7 @@ pub enum FileHandlerError {
     #[error("Unable to open file {0}")]
     OpenFile(String),
 
-    #[error("Unable to to read file {0}")]
+    #[error("Unable to read file {0}")]
     ReadFile(String),
 
     #[error("File is not a recognized format: {0:?}")]

rust/src/manager/wallet_manager.rs

@@ -634,7 +634,7 @@ impl RustWalletManager {
     #[uniffi::method]
     pub async fn number_of_confirmations(&self, block_height: u32) -> Result<u32, Error> {
         let current_height = self.current_block_height().await?;
-        Ok(current_height - block_height + 1)
+        if block_height > current_height { Ok(0) } else { Ok(current_height - block_height + 1) }
     }
 
     #[uniffi::method]
@@ -850,7 +850,7 @@ impl RustWalletManager {
                     WalletAddressType::WrappedSegwit => json.bip49.clone(),
                     WalletAddressType::Legacy => json.bip44.clone(),
                     _ => {
-                        error!("trying to swtich to native segwit, but already segwit");
+                        error!("trying to switch to native segwit, but already segwit");
                         return Ok(());
                     }
                 };

rust/src/multi_qr.rs

@@ -52,7 +52,7 @@ pub enum MultiQrError {
     #[error("Cannot add binary data to BBQR")]
     CannotAddBinaryDataToBbqr,
 
-    #[error("BBQr did not container seed words, found: {0}")]
+    #[error("BBQR did not contain seed words, found: {0}")]
     BbqrDidNotContainSeedWords(String),
 
     #[error(transparent)]

rust/src/reporting.rs

@@ -19,7 +19,7 @@ pub struct Csv(Vec<u8>);
 
 #[derive(Debug, thiserror::Error)]
 pub enum CsvCreationError {
-    #[error("failed to fianlize csv: {0}")]
+    #[error("failed to finalize csv: {0}")]
     FinalizeCsv(String),
 
     #[error("failed to write csv row: {0}")]
@@ -32,7 +32,7 @@ impl Csv {
     }
 
     pub fn into_string(self) -> String {
-        String::from_utf8(self.into_bytes()).expect("we only create rows with valid uft8 strings")
+        String::from_utf8(self.into_bytes()).expect("we only create rows with valid utf8 strings")
     }
 }
 type Row = TxnWithHistoricalPrice;