You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Update Sass variables that refer to e.g. padding-vertical, padding-horizontal to padding-block and padding-inline
See badges, buttons, inputs, selects etc.
The CSS properties should also be updated — we should not call a Sass variable padding-block but apply padding-top and padding-bottom in CSS, it should apply padding-block.
Update all instances of padding & margin to use the logical properties
This would make bitstyles more writing-direction friendly. Using padding and margin shorthands doesn’t apply logical properties, we’d have to split those out into their block and inline properties
The text was updated successfully, but these errors were encountered:
See the discussion here: #751 (comment)
Should we:
Update the default config for e.g. margin & padding utility classes to use
block
andinline
(including the naming of the classes)So
.u-margin-s4-y
becomes.u-margin-s4-block
,.u-padding-s4-x
becomes.u-padding-s4-inline
.The styles they apply would also be updated to match e.g.
Update Sass variables that refer to e.g.
padding-vertical
,padding-horizontal
topadding-block
andpadding-inline
See badges, buttons, inputs, selects etc.
The CSS properties should also be updated — we should not call a Sass variable
padding-block
but applypadding-top
andpadding-bottom
in CSS, it should applypadding-block
.Update all instances of padding & margin to use the logical properties
This would make bitstyles more writing-direction friendly. Using
padding
andmargin
shorthands doesn’t apply logical properties, we’d have to split those out into theirblock
andinline
propertiesThe text was updated successfully, but these errors were encountered: