Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use logical properties for padding & margin? #777

Open
planktonic opened this issue May 10, 2023 · 0 comments
Open

Use logical properties for padding & margin? #777

planktonic opened this issue May 10, 2023 · 0 comments

Comments

@planktonic
Copy link
Member

See the discussion here: #751 (comment)

Should we:

Update the default config for e.g. margin & padding utility classes to use block and inline (including the naming of the classes)

So .u-margin-s4-y becomes .u-margin-s4-block, .u-padding-s4-x becomes .u-padding-s4-inline.
The styles they apply would also be updated to match e.g.

.u-margin-s4-block {
  margin-block: var(--bs-size-s4);
}

Update Sass variables that refer to e.g. padding-vertical, padding-horizontal to padding-block and padding-inline

See badges, buttons, inputs, selects etc.

The CSS properties should also be updated — we should not call a Sass variable padding-block but apply padding-top and padding-bottom in CSS, it should apply padding-block.

Update all instances of padding & margin to use the logical properties

This would make bitstyles more writing-direction friendly. Using padding and margin shorthands doesn’t apply logical properties, we’d have to split those out into their block and inline properties

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant