Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom HTTP port in configuration file? #3

Open
natevw opened this issue Sep 15, 2021 · 0 comments
Open

Add support for custom HTTP port in configuration file? #3

natevw opened this issue Sep 15, 2021 · 0 comments

Comments

@natevw
Copy link

natevw commented Sep 15, 2021

One of the kids and I are trying to play with our own custom webserver for the PETdisk. The easiest way to do this is on a machine or VM on the LAN using a high-numbered (unprivileged) port like 8080.

I noticed however that the config parsing doesn't look for a : separator and instead port 80 is hardcoded in the HTTP client.

We were able to work around this with a port forward on our router, and there's probably other tricks available using ssh or nginx proxies or similar, but it would be convenient if a custom port number could be configured.

(Just browsing it in GitHub without the aid of an IDE, I couldn't 100% trace through how the host thing is handled with the offset but I think it might just be a matter of adding a port field around setUrlData assuming there's some sort of atoi conversion routine handy? Maybe I'll try a stab at it but always takes me a bit to set up each different toolchain and such.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant