Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIs with more than 2 digits not working #2

Open
csaar95 opened this issue Oct 13, 2021 · 6 comments
Open

AIs with more than 2 digits not working #2

csaar95 opened this issue Oct 13, 2021 · 6 comments

Comments

@csaar95
Copy link

csaar95 commented Oct 13, 2021

The parsing of following code 241ABC1234<FNC1>100815 results in:

 [{
   "identifier": "24",
   "value": "1ABC1234",
   "length": 8
 }, {
   "identifier": "10",
   "value": "0815",
   "length": 4
 }]

The AI 24 doesn't exist (https://www.gs1.org/standards/barcodes/application-identifiers), the correct result would've been identifier "241" and value "ABC1234".

Unortunately in this case the module is absolutely useless:/

@bitflower
Copy link
Owner

PRs welcome. This is open source ;-)

@csaar95 csaar95 changed the title AI 241 parsed as "24" AIs with more than 2 digits not working Oct 14, 2021
@csaar95
Copy link
Author

csaar95 commented Oct 14, 2021

Hello Matthias, after reading over ur code, I decided to solve it in a fresh piece of code.
I didn't see a possibility fixing the "design mistake" to only react on two digit AIs without rewriting mostly of the code.
I finished the parser today, and we'll probably publish it in the next time. I'll link it here!
Hopefully u'll don't take my criticism the wrong way.

@Remo
Copy link

Remo commented May 3, 2022

@csaar95 did you ever get to finish your code?

@csaar95
Copy link
Author

csaar95 commented May 3, 2022

@Remo It is, but I didnt publish it yet, are you interested?

@Remo
Copy link

Remo commented May 3, 2022

@csaar95 well, I am looking for a gs1 parser, so yes 😉

@AlexandreKueny
Copy link

@csaar95 I'm also really interested in a working parser 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants