Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrading from 3.4.3 to 3.5.1 dropped "Target Port" w/UDP #42

Open
MattRogish opened this issue Feb 6, 2025 · 1 comment
Open

Upgrading from 3.4.3 to 3.5.1 dropped "Target Port" w/UDP #42

MattRogish opened this issue Feb 6, 2025 · 1 comment

Comments

@MattRogish
Copy link

We are running generic OSC to connect to qLab via UDP. Upon upgrading from 3.4.3 to 3.5.1, the "Target Port" was blank (and the connection was "Green" as if it was OK). This took a bit of time to diagnose why OSC messages weren't getting through.

It seems there are two bugs here:

  1. Upgrading dropped the target port
  2. Blank target ports should mark the connection as broken, not green (I assume there is probably some edge-case condition here because typically the port should never be blank)

Thanks!

--
Matt
logicallysynced added a commit to logicallysynced/companion-module-generic-osc that referenced this issue Feb 9, 2025
@logicallysynced
Resolved issue bitfocus#42
5131c94 
Updated companion yarn dependencies.
Added additional null checks to hostname and targetPort.
Added regex and required fields to hostname and targetPort.
@logicallysynced logicallysynced mentioned this issue Feb 9, 2025
Merged
@logicallysynced
Copy link
Collaborator

Hey @MattRogish, I've created a PR to address these issues. Will need to wait on module maintainers to review, merge and request inclusion in the next Companion release.

Julusian added a commit that referenced this issue Feb 16, 2025
@Julusian
Merge pull request #43 from logicallysynced/targetport-issue-resolve
8f84564 
Resolved issue #42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MattRogish @logicallysynced