[binami/kafka] Setting broker.rack for azure based on brokerRackAssignment parameter #31496
+18
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
based on documentation provided by https://learn.microsoft.com/en-us/azure/virtual-machines/instance-metadata-service?tabs=linux. Choosen API version, latests available as default option. Signed-off-by: Norbert Jakubiak <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
carrodher
added
verify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
.Values.brokerRackAssignmenthas been extended by additional optionazurebased on documentation provided by Microsoft. There is additional parameter added, because Microsoft API doesn't support version "latest". Currently latest available has been put as default value in values.yaml file with possibility to overwrite it through parameter.Values.brokerRackAssignmentApiVersion("2023-11-15" as default.) Rack id contains region-zone to make it more highly available in multi-region clusters (and doesn't affect in any way clusters in one region).Benefits
Adds broker.rack support for azure kubernetes which gives more possibility than only having AWS.
Possible drawbacks
At some point in the future API version will get deprecated and default value would need to be updated.
Applicable issues
Additional information
N/A
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm