Skip to content
This repository has been archived by the owner on Jun 8, 2020. It is now read-only.

Bitmex execution reports needs to be resubmitted as a PR #243

Closed
badgerwithagun opened this issue Oct 25, 2018 · 1 comment
Closed

Bitmex execution reports needs to be resubmitted as a PR #243

badgerwithagun opened this issue Oct 25, 2018 · 1 comment

Comments

@badgerwithagun
Copy link
Collaborator

#191 originally contained Bitmex execution report support submitted by @KapitalTrading. It had heavy overlap with some other urgent PRs, so maintaining a "roll up" of these PRs (which I did in #191) was the only practical way of managing the conflicts during the months when PRs weren't getting applied.

Now, however, things are moving and we are slowly clearing the backlog of urgent PRs.

This Bitmex functionality was mixed in with various other useful performance tweaks and bug fixes which we wanted to get merged urgently. However, we have been short of Bitmex testers/reviewers so this functionality was extracted from that PR with the intention of reapplying it later:

Reversal commit from the #191 branch: 55513ff

I have a task to resubmit a PR with this functionality re-applied. It will be broken though (the XChange 4.3.11 upgrade broke it) so I'll need to re-assign it to someone else to finish off (I don't use Bitmex).

This is just a placeholder so I remember to do it.

@badgerwithagun
Copy link
Collaborator Author

Raised #244

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant