review: improve shell script variable quoting for better practices

Update shell script to use proper variable quoting syntax throughout
(${VARIABLE} instead of $VARIABLE) for better shell scripting practices
and consistency. This change was requested during code review to follow
shell scripting best practices.

While this won't cause problems in practice, it prevents potential
word splitting issues and improves code maintainability.

Author: addisonbeck

.github/workflows/sdk-breaking-change-check.yml

@@ -48,13 +48,13 @@ jobs:
         run: |
           echo "🔍 Validating required client_payload fields..."
           
-          if [ -z "$SOURCE_REPO" ] || [ -z "$SDK_VERSION" ] || [ -z "$ARTIFACTS_RUN_ID" ] || [ -z "$ARTIFACT_NAME" ]; then
+          if [ -z "${SOURCE_REPO}" ] || [ -z "${SDK_VERSION}" ] || [ -z "${ARTIFACTS_RUN_ID}" ] || [ -z "${ARTIFACT_NAME}" ]; then
             echo "::error::Missing required client_payload fields"
-            echo "SOURCE_REPO: $SOURCE_REPO"
-            echo "SDK_VERSION: $SDK_VERSION"  
-            echo "ARTIFACTS_RUN_ID: $ARTIFACTS_RUN_ID"
-            echo "ARTIFACT_NAME: $ARTIFACT_NAME"
-            echo "CLIENT_LABEL: $CLIENT_LABEL"
+            echo "SOURCE_REPO: ${SOURCE_REPO}"
+            echo "SDK_VERSION: ${SDK_VERSION}"  
+            echo "ARTIFACTS_RUN_ID: ${ARTIFACTS_RUN_ID}"
+            echo "ARTIFACT_NAME: ${ARTIFACT_NAME}"
+            echo "CLIENT_LABEL: ${CLIENT_LABEL}"
             exit 1
           fi
           
@@ -83,37 +83,37 @@ jobs:
           
           RETRY_COUNT=0
           MAX_RETRIES=3
-          while [ $RETRY_COUNT -lt $MAX_RETRIES ]; do
+          while [ ${RETRY_COUNT} -lt ${MAX_RETRIES} ]; do
             RETRY_COUNT=$((RETRY_COUNT + 1))
-            echo "🔄 npm ci attempt $RETRY_COUNT of $MAX_RETRIES..."
+            echo "🔄 npm ci attempt ${RETRY_COUNT} of ${MAX_RETRIES}..."
             
             if npm ci; then
               echo "✅ npm ci successful"
               break
             else
-              echo "❌ npm ci attempt $RETRY_COUNT failed"
-              [ $RETRY_COUNT -lt $MAX_RETRIES ] && sleep 5
+              echo "❌ npm ci attempt ${RETRY_COUNT} failed"
+              [ ${RETRY_COUNT} -lt ${MAX_RETRIES} ] && sleep 5
             fi
           done
           
-          if [ $RETRY_COUNT -eq $MAX_RETRIES ] && ! npm ci; then
-            echo "::error::npm ci failed after $MAX_RETRIES attempts"
+          if [ ${RETRY_COUNT} -eq ${MAX_RETRIES} ] && ! npm ci; then
+            echo "::error::npm ci failed after ${MAX_RETRIES} attempts"
             exit 1
           fi
 
       - name: Download SDK artifacts
         env:
           GH_TOKEN: ${{ steps.app-token.outputs.token }}
         run: |
-          echo "📥 Downloading SDK artifacts for $CLIENT_LABEL client from $SOURCE_REPO run $ARTIFACTS_RUN_ID..."
+          echo "📥 Downloading SDK artifacts for ${CLIENT_LABEL} client from ${SOURCE_REPO} run ${ARTIFACTS_RUN_ID}..."
           
           # Download SDK artifacts with error handling
-          if ! gh run download $ARTIFACTS_RUN_ID \
-              --repo $SOURCE_REPO \
-              --name $ARTIFACT_NAME \
+          if ! gh run download ${ARTIFACTS_RUN_ID} \
+              --repo ${SOURCE_REPO} \
+              --name ${ARTIFACT_NAME} \
               --dir ./temp-sdk-artifacts; then
-            echo "::error::Failed to download SDK artifacts from run $ARTIFACTS_RUN_ID"
-            echo "::error::Repository: $SOURCE_REPO, Artifact: $ARTIFACT_NAME"
+            echo "::error::Failed to download SDK artifacts from run ${ARTIFACTS_RUN_ID}"
+            echo "::error::Repository: ${SOURCE_REPO}, Artifact: ${ARTIFACT_NAME}"
             exit 1
           fi
           
@@ -131,8 +131,8 @@ jobs:
       - name: Install SDK locally and run type check
         run: |
           echo "🔧 Installing SDK artifacts locally..."
-          echo "📊 SDK Version: $SDK_VERSION"
-          echo "📦 Artifact Source: $SOURCE_REPO run $ARTIFACTS_RUN_ID"
+          echo "📊 SDK Version: ${SDK_VERSION}"
+          echo "📦 Artifact Source: ${SOURCE_REPO} run ${ARTIFACTS_RUN_ID}"
           
           # Create local package and install
           mkdir -p ./local-sdk-package
@@ -144,15 +144,15 @@ jobs:
           echo "🔗 Installing local SDK package..."
           npm install ./local-sdk-package
           
-          echo "🔍 Running TypeScript type checking for $CLIENT_LABEL client with SDK version: $SDK_VERSION"
+          echo "🔍 Running TypeScript type checking for ${CLIENT_LABEL} client with SDK version: ${SDK_VERSION}"
           echo "🎯 Type checking command: npm run test:types"
           
           # Add GitHub Step Summary output
-          echo "## 📊 TypeScript Compatibility Check ($CLIENT_LABEL)" >> $GITHUB_STEP_SUMMARY
-          echo "- **Client**: $CLIENT_LABEL" >> $GITHUB_STEP_SUMMARY
-          echo "- **SDK Version**: $SDK_VERSION" >> $GITHUB_STEP_SUMMARY
-          echo "- **Source Repository**: $SOURCE_REPO" >> $GITHUB_STEP_SUMMARY
-          echo "- **Artifacts Run ID**: $ARTIFACTS_RUN_ID" >> $GITHUB_STEP_SUMMARY
+          echo "## 📊 TypeScript Compatibility Check (${CLIENT_LABEL})" >> $GITHUB_STEP_SUMMARY
+          echo "- **Client**: ${CLIENT_LABEL}" >> $GITHUB_STEP_SUMMARY
+          echo "- **SDK Version**: ${SDK_VERSION}" >> $GITHUB_STEP_SUMMARY
+          echo "- **Source Repository**: ${SOURCE_REPO}" >> $GITHUB_STEP_SUMMARY
+          echo "- **Artifacts Run ID**: ${ARTIFACTS_RUN_ID}" >> $GITHUB_STEP_SUMMARY
           echo "" >> $GITHUB_STEP_SUMMARY
           
           TYPE_CHECK_START=$(date +%s)
@@ -161,15 +161,15 @@ jobs:
           if timeout 10m npm run test:types; then
             TYPE_CHECK_END=$(date +%s)
             TYPE_CHECK_DURATION=$((TYPE_CHECK_END - TYPE_CHECK_START))
-            echo "✅ TypeScript compilation successful for $CLIENT_LABEL client (${TYPE_CHECK_DURATION}s)"
+            echo "✅ TypeScript compilation successful for ${CLIENT_LABEL} client (${TYPE_CHECK_DURATION}s)"
             echo "✅ **Result**: TypeScript compilation successful" >> $GITHUB_STEP_SUMMARY
-            echo "No breaking changes detected in $CLIENT_LABEL client for SDK version $SDK_VERSION" >> $GITHUB_STEP_SUMMARY
+            echo "No breaking changes detected in ${CLIENT_LABEL} client for SDK version ${SDK_VERSION}" >> $GITHUB_STEP_SUMMARY
           else
             TYPE_CHECK_END=$(date +%s)
             TYPE_CHECK_DURATION=$((TYPE_CHECK_END - TYPE_CHECK_START))
-            echo "❌ TypeScript compilation failed for $CLIENT_LABEL client after ${TYPE_CHECK_DURATION}s - breaking changes detected"
+            echo "❌ TypeScript compilation failed for ${CLIENT_LABEL} client after ${TYPE_CHECK_DURATION}s - breaking changes detected"
             echo "❌ **Result**: TypeScript compilation failed" >> $GITHUB_STEP_SUMMARY
-            echo "Breaking changes detected in $CLIENT_LABEL client for SDK version $SDK_VERSION" >> $GITHUB_STEP_SUMMARY
+            echo "Breaking changes detected in ${CLIENT_LABEL} client for SDK version ${SDK_VERSION}" >> $GITHUB_STEP_SUMMARY
             exit 1
           fi