Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] Pressing Esc to close a dropdown menu closes extension window #12525

Open
1 task done
patrickhlauke opened this issue Dec 21, 2024 · 3 comments
Open
1 task done
Labels
browser Browser Extension bug

Comments

@patrickhlauke
Copy link
Contributor

patrickhlauke commented Dec 21, 2024

Steps To Reproduce

  1. Open extension window
  2. Go to "Vault"
  3. Open a filter dropdown menu
  4. Press Esc to close the dropdown

Expected Result

Esc should close the menu, reset focus back to the button to open the menu

Actual Result

The extension's window is closed

Screenshots or Videos

bitwarden-dropdown-menu-esc-to-close-closes-extension.mp4

Video: Chrome/Windows, opening "Vault" dropdown menu with the keyboard, navigating up/down with cursor keys, pressing Esc to close menu

Additional Context

This does not happen when extension has been popped out into its own window - there, it behaves correctly. Suspect the solution here is to prevent the Esc keypress from bubbling up and triggering the "close the entire extension popup" behaviour.

This happens with all instances of custom dropdown menus, like the "+ New" button menu, the "New send" one, etc.

Operating System

Windows

Operating System Version

11

Web Browser

Chrome

Browser Version

131.0.6778.205 (Official Build) (64-bit)

Build Version

2024.12.2

Issue Tracking Info

  • I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.
@patrickhlauke patrickhlauke added browser Browser Extension bug labels Dec 21, 2024
@bitwarden-bot
Copy link

Thank you for reporting this issue! We've added this to our internal tracking system.
ID: PM-16291

@patrickhlauke
Copy link
Contributor Author

Some more examples of when this happens...

github-extension-more-esc-examples.mp4

Video: Chrome/Windows - three-dot menu for item in the vault, "+ New" menu at the top of the extension, "Add Field > Field type" select/dropdown (this closes the whole "Add Field" modal, not the whole extension window, but the cause is still the same ... Esc bubbling up), "New send" menu,

@SergeantConfused
Copy link

Hello @patrickhlauke,

Thank you for your report. I have flagged this to the Engineering department; please feel free to post additional information, such as screenshots or a screen video recordings, if you wish.

Thank you again,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser Browser Extension bug
Projects
None yet
Development

No branches or pull requests

3 participants