Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] "Bitwarden has a new look" first-run modal dialog isn't modal #12529

Open
1 task done
patrickhlauke opened this issue Dec 21, 2024 · 2 comments
Open
1 task done
Labels
browser Browser Extension bug

Comments

@patrickhlauke
Copy link
Contributor

Steps To Reproduce

  1. Do a fresh update/install of the extension
  2. Log into/unlock your vault
  3. See the "Bitwarden has a new look" dialog

Expected Result

Initial focus should be set on the modal dialog. Using Tab/Shift+Tab, focus should be kept inside the modal dialog. The underlying document behind the modal dialog should be hidden from screen readers/assistive technologies.

Actual Result

Focus is not set into the modal dialog when it's shown.

Focus is not locked to the dialog - a user is able to navigate through the underlying document behind the open modal dialog.

The document behind the modal dialog is still exposed to screen readers/assistive technologies.

Screenshots or Videos

No response

Additional Context

screenshot of the extension showing the first-run modal dialog, but keyboard focus is visible behind the dialog

You can see in the screenshot that keyboard focus is behind the modal dialog.

Suspect that this first-run dialog was not triggered properly / didn't do focus management correctly.

Operating System

Windows

Operating System Version

11

Web Browser

Chrome

Browser Version

131.0.6778.205 (Official Build) (64-bit)

Build Version

2024.12.2

Issue Tracking Info

  • I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.
@patrickhlauke patrickhlauke added browser Browser Extension bug labels Dec 21, 2024
@bitwarden-bot
Copy link

Thank you for reporting this issue! We've added this to our internal tracking system.
ID: PM-16295

@SergeantConfused
Copy link

Hello @patrickhlauke,

Thank you for your report. I have flagged this to the Engineering department; please feel free to post additional information, such as screenshots or a screen video recordings, if you wish.

Thank you again,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser Browser Extension bug
Projects
None yet
Development

No branches or pull requests

3 participants