Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] "Password history" control not keyboard focusable #12530

Open
1 task done
patrickhlauke opened this issue Dec 21, 2024 · 2 comments
Open
1 task done
Labels
browser Browser Extension bug

Comments

@patrickhlauke
Copy link
Contributor

Steps To Reproduce

  1. Go to an entry with a password history
  2. Use Tab to reach the "Password history" control

Expected Result

"Password history" can be focused and activated with the keyboard.

Actual Result

"Password history" is currently rendered as an <a> element without an href. This means it's not keyboard-focusable by default, so can't be reached/activated by keyboard users.

Screenshots or Videos

screenshot showing the 'Password history' control, and chrome developer tools showing that it's an 'a' element without an 'href'

Additional Context

This should either be forced to be focusable (adding tabindex="0" and role="link"), or turned into an actual <button> element.

Operating System

Windows

Operating System Version

11

Web Browser

Chrome

Browser Version

131.0.6778.205 (Official Build) (64-bit)

Build Version

2024.12.2

Issue Tracking Info

  • I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.
@patrickhlauke patrickhlauke added browser Browser Extension bug labels Dec 21, 2024
@bitwarden-bot
Copy link

Thank you for reporting this issue! We've added this to our internal tracking system.
ID: PM-16296

@SergeantConfused
Copy link

Hello @patrickhlauke,

Thank you for your report. I have flagged this to the Engineering department; please feel free to post additional information, such as screenshots or a screen video recordings, if you wish.

Thank you again,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser Browser Extension bug
Projects
None yet
Development

No branches or pull requests

3 participants