Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] Illogical focus order for "+ New URI" / "+ New custom field" #12540

Open
1 task done
patrickhlauke opened this issue Dec 22, 2024 · 2 comments
Open
1 task done
Labels
bug desktop Desktop Application

Comments

@patrickhlauke
Copy link
Contributor

Steps To Reproduce

  1. Add or edit an item
  2. Navigate with the keyboard to the "+ New URI" button, and activate it
  3. Same, but with the "+ New custom field" button

Expected Result

Once the "+ New URI" button is activated, the new input field appears. Focus is moved programmatically to the new input field.

Same for "+ New custom field" - two new inputs (Name and Value) appear. Focus is moved programmatically to the "Name" field.

Actual Result

The new input(s) appear, but focus remains on the "+ New URI" / "+ New custom field" button. No hint is given to screen reader users that anything actually happened. As the new fields are inserted before the "+ ..." buttons, a user has to navigate in reverse (Shift+Tab) to reach them (assuming they know that anything actually happened).

Screenshots or Videos

bitwarden-desktop-add-new-focus-order.mp4

Video: Windows/NVDA, triggering the "+ New URI" button, no announcement is made, then having to Shift+Tab to reach the new field. Same for the "+ New custom field" - here even more annoying, as when using Shift+Tab the user first encounters the Value field, so they need to reverse-navigate once more to reach the Name field.

Additional Context

Once these "+ ..." buttons are triggered, move .focus() to the first newly shown input. This will then also take care of announcing to screen readers that something actually happened, as the new input will be announced.

Operating System

Windows

Operating System Version

11

Installation method

Direct Download (from bitwarden.com)

Build Version

2024.12.1

Issue Tracking Info

  • I understand that work is tracked outside of GitHub. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.
@patrickhlauke patrickhlauke added bug desktop Desktop Application labels Dec 22, 2024
@bitwarden-bot
Copy link

Thank you for reporting this issue! We've added this to our internal tracking system.
ID: PM-16309

@SergeantConfused
Copy link

Hello @patrickhlauke,

Thank you for your report. I have flagged this to the Engineering department; please feel free to post additional information, such as screenshots or a screen video recordings, if you wish.

Thank you again,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug desktop Desktop Application
Projects
None yet
Development

No branches or pull requests

3 participants