-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Show Identities as Autofill Suggestions on Vault View" Almost Never Works #12553
Comments
Thank you for reporting this issue! We've added this to our internal tracking system. |
Hi there! We appreciate you letting us know of this issue. Due to the nature of autofill issues, we track them internally using different Forms depending on the platform:
In this case, we will go ahead and file an autofill report for you with the information you added here. In the future, if you encounter any other page or app that doesn't autofill as expected, please avoid opening a new GitHub issue and go directly to the corresponding form. This issue will now be closed. Thanks! |
@Greenderella @micahblut This issue is not an autofill issue. It is a bug in rendering of the "Autofill Suggestions" area on the Vault page of the new browser extension. As I confirmed in Step 6 of the "Steps to Reproduce", the auto-filling functionality does actually work on all 30 URLs listed as examples. The problem is that the UI fails to display the Fill button. Please re-open. |
@dpantel What URL do you have open in the browser? It needs to contain input fields for identity or payment info for this functionality to even have a chance of working. However, this bug report shows that the expected functionality does not work, except in very rare cases (10% of sites). |
It was an online order site that contained both address and payment fields. I would argue that BW should not try to detect or match those types of fields to determine if Identities or Cards should be displayed. I would argue that if I enable those settings, I expect to always see Identities/Cards towards the top of the extension window, after suggested logins. They can be in their own sections, if that's what the designers like, such as
The main reason is that historically, BW is terrible at filling out identity/card information, likely due to the high variability in form field ids. So, it is not unusual to have to manually copy and paste some of this info. Therefore, I want those at the top of the extension window, for easy repeated access on the same form. |
Thanks for clarifying. Seeing your GitHub login item as an autofill suggestion in the screenshot threw me off.
I do agree with you, but what you're proposing would be a new feature (actually, resurrection of an old feature), and not a bug fix. Here is the applicable Feature Request thread:
In the meantime, I'm trying to get somebody at Bitwarden to understand that the issue reported in this thread is not just an autofill issue, it is a bug in the construction of the browser extension's Vault page contents. I may have to refile the issue with a different title and better explanations. |
You reported a bug. To summarize: definitely a bug; needs fixing. |
Thank you.
What I think doesn't matter, but in my experience, Bitwarden reps will promptly close GitHub issues that are deemed to involve intended behavior that may be undesired (i.e., a feature request). Here, @Greenderella has already closed this issue because they mistakenly got the impression that I was reporting an autofill failure. I am trying to campaign to have the issue re-opened as a bug report ticket, so giving them any additional ammunition that could justify keeping the issue closed (e.g., posting of feature requests in the thread) is something that I would prefer to avoid. |
We'll just agree to disagree. In any case, this issue was (improperly) closed before I even got here. @Greenderella Please reopen this issue or I will create a new one. |
Already posted a new issue, with hopefully a better title and description: |
Steps To Reproduce
Examples of Identity Forms Where Issue is Observed:
Expected Result
According to this statement by @micahblut, it is expected that Identity items should appear in the browser extension's "Autofill Suggestions" section "when the user is on a page with a form that we detect as a valid place to fill that data."
The presence of a web form that is a "valid place to fill that data" is confirmed by performing Step 6 in the above instructions for reproducing the issue. All of the example websites listed above satisfy this criterion, so it is expected that Identity items should appear in the browser extension's "Autofill Suggestions" section when any of the above web pages has been loaded.
Actual Result
Despite the presence of valid input fields for Identity data, no Identity items are displayed in the "Autofill Suggestions" section.
Screenshots or Videos
No response
Additional Context
The above list of websites was selected at random from a Google search for "address signup form". Out of 36 web forms tested, Identities were successfully displayed as autofill suggestions in only 4 cases (a failure rate approaching 90%). For the record (and to assist with debugging), these are the four sites where the new feature works as intended:
Even prior to release of this buggy feature (in 2024.12.0), autofilling using any method will not work when the form fields are not visible (e.g., hidden, or below the scroll). However, in the old UI (2024.11.2 and earlier), it was possible to autofill Identities (and other data) after making the form fields visible (e.g., by scrolling the web page). Therefore, it is important to note that for all of the example URLs listed in the above instructions for reproducing the issue, at least some of the form input fields were visible in the web browser on page load (and could be successfully autofilled using the right-click context menu, as verified in Step 6 above).
For the record (and for testing purposes), here are 3 examples of web forms where Identity information cannot be autofilled by the right-click context menu until after the forms fields have been made visible (by scrolling, or by selecting a form option):
For the above three examples, the browser extension also does not display Identity items as autofill suggestions.
Operating System
Windows
Operating System Version
Windows 11 (23H2)
Web Browser
Chrome
Browser Version
No response
Build Version
Version: 2024.12.3; SDK: 'main (edee180)'
Issue Tracking Info
The text was updated successfully, but these errors were encountered: