From b09057e9c7cfa97a101c8cf737d52e04fa2d2b32 Mon Sep 17 00:00:00 2001 From: Justin Baur <19896123+justindbaur@users.noreply.github.com> Date: Wed, 4 Dec 2024 11:27:20 -0500 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Matt Bishop --- .github/workflows/release.yml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 724dcec..73cd853 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -23,7 +23,7 @@ env: jobs: build-artifact: - name: Build Artifact + name: Build artifacts runs-on: ubuntu-22.04 steps: - name: Check out repo @@ -38,7 +38,7 @@ jobs: env: IS_PRERELEASE: ${{ inputs.type == 'prerelease' }} - - name: Get Current Version + - name: Get current version id: current-version run: echo "VERSION=$(dotnet msbuild -p:IsPreRelease=$IS_PRERELEASE --getProperty:Version)" env: @@ -52,7 +52,7 @@ jobs: const package = '${{ inputs.package }}'; const currentVersion = '${{ steps.current-version.outputs.VERSION }}'; - // configure git + // Configure Git await exec.exec(`git config user.name "github-actions"`); await exec.exec(`git config user.email "github-actions@github.com"`); @@ -98,14 +98,14 @@ jobs: console.log("Finished creating release."); - - name: Run Version Bumper + - name: Bump version id: version-bumper shell: pwsh env: PACKAGE_NAME: ${{ inputs.package }} BUMP_TYPE: ${{ inputs.type }} run: | - echo "NEW_VERSION=$(./scrips/UpdatePackageVersion.ps1 -PackageName $env:PACKAGE_NAME -BumpType $env:BUMP_TYPE)" >> $env:GITHUB_OUTPUT + echo "NEW_VERSION=$(./scripts/UpdatePackageVersion.ps1 -PackageName $env:PACKAGE_NAME -BumpType $env:BUMP_TYPE)" >> $env:GITHUB_OUTPUT - name: Create PR uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1 @@ -116,7 +116,7 @@ jobs: const bumpType = '${{ inputs.type }}'; const newVersion = '${{ steps.version-bumper.outputs.NEW_VERSION }}'; - // configure git + // Configure Git await exec.exec(`git config user.name "github-actions"`); await exec.exec(`git config user.email "github-actions@github.com"`); @@ -131,7 +131,7 @@ jobs: shouldOpenPullRequest = false; } catch { } - // add and commit changes + // Add and commit changes const commitMessage = `Bump ${packageName} version to ${newVersion}`; const gitCommitCommand = `git commit --all --message "${commitMessage}"`; let gitCommitOutput = `$ ${gitCommitCommand}\n\n`;