added BitwardenMenuFooterView to uniformize style

Author: aj-rosado

BitwardenShared/UI/Platform/Application/Views/BitwardenMenuField.swift

@@ -346,11 +346,11 @@ struct BitwardenMenuField<
             Group {
                 Divider()
                 if let footerContent = footerContent as? Text {
-                    footerContent
-                        .styleGuide(.footnote, includeLinePadding: false, includeLineSpacing: false)
-                        .foregroundColor(SharedAsset.Colors.textSecondary.swiftUIColor)
-                        .multilineTextAlignment(.leading)
-                        .padding(.vertical, 12)
+                    BitwardenMenuFooterTextField(
+                        footerContent,
+                        topPadding: 12,
+                        bottomPadding: 12
+                    )
                 } else {
                     footerContent
                 }

BitwardenShared/UI/Platform/Application/Views/BitwardenMenuFooterTextView.swift

@@ -0,0 +1,46 @@
+import BitwardenResources
+import SwiftUI
+
+// MARK: - BitwardenMenuFooterTextField
+
+/// A text view for the footer on BitwardenMenu
+///
+struct BitwardenMenuFooterTextField: View {
+    
+    /// The content of the text view.
+    private let content: Text
+    
+    /// The bottom padding of the text view.
+    private let topPadding: CGFloat
+    
+    /// The bottom padding of the text view.
+    private let bottomPadding: CGFloat
+
+    init(_ content: Text, topPadding: CGFloat = 0, bottomPadding: CGFloat = 12) {
+        self.content = content
+        self.topPadding = topPadding
+        self.bottomPadding = bottomPadding
+    }
+    
+    init(_ title: LocalizedStringKey, topPadding: CGFloat = 0, bottomPadding: CGFloat = 12) {
+        content = Text(title)
+        self.topPadding = topPadding
+        self.bottomPadding = bottomPadding
+    }
+    
+    init(_ title: String, topPadding: CGFloat = 0, bottomPadding: CGFloat = 12) {
+        content = Text(title)
+        self.topPadding = topPadding
+        self.bottomPadding = bottomPadding
+    }
+
+    // MARK: View
+    var body: some View {
+        content
+            .styleGuide(.footnote, includeLinePadding: false, includeLineSpacing: false)
+            .foregroundColor(SharedAsset.Colors.textSecondary.swiftUIColor)
+            .multilineTextAlignment(.leading)
+            .padding(.top, topPadding)
+            .padding(.bottom, bottomPadding)
+    }
+}

BitwardenShared/UI/Platform/Settings/Settings/AutoFill/AutoFillView.swift

@@ -72,7 +72,7 @@ struct AutoFillView: View {
                 accessibilityIdentifier: "CopyTotpAutomaticallySwitch"
             )
             .contentBlock()
-
+            
             BitwardenMenuField(
                 title: Localizations.defaultUriMatchDetection,
                 accessibilityIdentifier: "DefaultUriMatchDetectionChooser",
@@ -83,19 +83,18 @@ struct AutoFillView: View {
                 )
             ) {
                 VStack(alignment: .leading, spacing: 0) {
-                    Text(Localizations.uriMatchDetectionControlsHowBitwardenIdentifiesAutofillSuggestions)
-                        .styleGuide(.footnote, includeLinePadding: false, includeLineSpacing: false)
-                        .foregroundColor(SharedAsset.Colors.textSecondary.swiftUIColor)
-                        .multilineTextAlignment(.leading)
-                        .padding(.top, 12)
-                        .padding(.bottom, store.state.warningMessage == nil ? 12 : 4)
+                    BitwardenMenuFooterTextField(
+                        Localizations.uriMatchDetectionControlsHowBitwardenIdentifiesAutofillSuggestions,
+                        topPadding: 12,
+                        bottomPadding: store.state.warningMessage == nil ? 12 : 4
+                    )
 
                     store.state.warningMessage.map { warningMessage in
-                        Text(LocalizedStringKey(warningMessage))
-                            .styleGuide(.footnote, includeLinePadding: false, includeLineSpacing: false)
-                            .foregroundColor(SharedAsset.Colors.textSecondary.swiftUIColor)
-                            .multilineTextAlignment(.leading)
-                            .padding(.bottom, 12)
+                        BitwardenMenuFooterTextField(
+                            LocalizedStringKey(warningMessage),
+                            topPadding: 0,
+                            bottomPadding: 12
+                        )
                     }
                 }
             }