[PM-24715] [RC] Fix iOS autofill extension app initialization URLs (#1858)

Author: fedemkr

BitwardenAutoFillExtension/CredentialProviderViewController.swift

@@ -68,10 +68,12 @@ class CredentialProviderViewController: ASCredentialProviderViewController {
             return
         }
 
-        initializeApp(
-            with: DefaultCredentialProviderContext(.autofillCredential(credentialIdentity, userInteraction: false))
-        )
-        provideCredential(for: recordIdentifier)
+        Task {
+            await initializeAppWithoutUserInteraction(
+                with: DefaultCredentialProviderContext(.autofillCredential(credentialIdentity, userInteraction: false))
+            )
+            provideCredential(for: recordIdentifier)
+        }
     }
 
     @available(iOSApplicationExtension 17.0, *)
@@ -82,12 +84,14 @@ class CredentialProviderViewController: ASCredentialProviderViewController {
                 provideCredentialWithoutUserInteraction(for: passwordIdentity)
             }
         case let passkeyRequest as ASPasskeyCredentialRequest:
-            initializeApp(
-                with: DefaultCredentialProviderContext(
-                    .autofillFido2Credential(passkeyRequest, userInteraction: false)
+            Task {
+                await initializeAppWithoutUserInteraction(
+                    with: DefaultCredentialProviderContext(
+                        .autofillFido2Credential(passkeyRequest, userInteraction: false)
+                    )
                 )
-            )
-            provideFido2Credential(for: passkeyRequest)
+                provideFido2Credential(for: passkeyRequest)
+            }
         default:
             if #available(iOSApplicationExtension 18.0, *),
                let otpRequest = credentialRequest as? ASOneTimeCodeCredentialRequest,
@@ -162,6 +166,15 @@ class CredentialProviderViewController: ASCredentialProviderViewController {
             }
         }
     }
+    
+    /// Sets up and initializes the app without user interaction.
+    /// - Parameter context: The context that describes how the extension is being used.
+    private func initializeAppWithoutUserInteraction(
+        with context: CredentialProviderContext
+    ) async {
+        initializeApp(with: context)
+        await appProcessor?.prepareEnvironmentConfig()
+    }
 
     /// Attempts to provide the credential with the specified ID to the extension context to handle
     /// autofill.
@@ -264,10 +277,12 @@ class CredentialProviderViewController: ASCredentialProviderViewController {
             return
         }
 
-        initializeApp(
-            with: DefaultCredentialProviderContext(.autofillOTPCredential(otpIdentity, userInteraction: false))
-        )
-        provideOTPCredential(for: recordIdentifier)
+        Task {
+            await initializeAppWithoutUserInteraction(
+                with: DefaultCredentialProviderContext(.autofillOTPCredential(otpIdentity, userInteraction: false))
+            )
+            provideOTPCredential(for: recordIdentifier)
+        }
     }
 }
 

BitwardenShared/UI/Platform/Application/AppProcessor.swift

@@ -183,8 +183,7 @@ public class AppProcessor {
         )
 
         await services.migrationService.performMigrations()
-        await services.environmentService.loadURLsForActiveAccount()
-        _ = await services.configService.getConfig()
+        await prepareEnvironmentConfig()
         await completeAutofillAccountSetupIfEnabled()
 
         if let initialRoute {
@@ -243,6 +242,13 @@ public class AppProcessor {
         await checkIfLockedAndPerformNavigation(route: route)
     }
 
+    /// Perpares the current environment configuration by loading the URLs for the active account
+    /// and getting the current server config.
+    public func prepareEnvironmentConfig() async {
+        await services.environmentService.loadURLsForActiveAccount()
+        _ = await services.configService.getConfig()
+    }
+
     // MARK: Autofill Methods
 
     /// Returns a `ASPasswordCredential` that matches the user-requested credential which can be

BitwardenShared/UI/Platform/Application/AppProcessorTests.swift

@@ -21,6 +21,7 @@ class AppProcessorTests: BitwardenTestCase { // swiftlint:disable:this type_body
     var clientService: MockClientService!
     var configService: MockConfigService!
     var coordinator: MockCoordinator<AppRoute, AppEvent>!
+    var environmentService: MockEnvironmentService!
     var errorReporter: MockErrorReporter!
     var fido2UserInterfaceHelper: MockFido2UserInterfaceHelper!
     var eventService: MockEventService!
@@ -56,6 +57,7 @@ class AppProcessorTests: BitwardenTestCase { // swiftlint:disable:this type_body
         coordinator = MockCoordinator()
         appModule.authRouter = router
         appModule.appCoordinator = coordinator
+        environmentService = MockEnvironmentService()
         errorReporter = MockErrorReporter()
         fido2UserInterfaceHelper = MockFido2UserInterfaceHelper()
         eventService = MockEventService()
@@ -81,6 +83,7 @@ class AppProcessorTests: BitwardenTestCase { // swiftlint:disable:this type_body
                 autofillCredentialService: autofillCredentialService,
                 clientService: clientService,
                 configService: configService,
+                environmentService: environmentService,
                 errorReporter: errorReporter,
                 eventService: eventService,
                 fido2UserInterfaceHelper: fido2UserInterfaceHelper,
@@ -107,6 +110,7 @@ class AppProcessorTests: BitwardenTestCase { // swiftlint:disable:this type_body
         clientService = nil
         configService = nil
         coordinator = nil
+        environmentService = nil
         errorReporter = nil
         fido2UserInterfaceHelper = nil
         eventService = nil
@@ -1440,4 +1444,12 @@ class AppProcessorTests: BitwardenTestCase { // swiftlint:disable:this type_body
         XCTAssertTrue(coordinator.isLoadingOverlayShowing)
         XCTAssertTrue(coordinator.events.isEmpty)
     }
+
+    /// `prepareEnvironmentConfig()` loads the URLs for the active account and the configuration.
+    @MainActor
+    func test_prepareEnvironmentConfig() async throws {
+        await subject.prepareEnvironmentConfig()
+        XCTAssertTrue(environmentService.didLoadURLsForActiveAccount)
+        XCTAssertTrue(configService.configMocker.called)
+    }
 }