From 1a98f44aa6ada0b93952d970455ec6d85c039e8f Mon Sep 17 00:00:00 2001
From: Federico Maccaroni <fedemkr@gmail.com>
Date: Mon, 13 Jan 2025 18:20:52 -0300
Subject: [PATCH 1/2] PM-15360 Fail CXP export if disable personal vault export
 policy is enabled.

---
 .../ExportCXF/ExportCXFProcessor.swift        | 12 ++++++
 .../ExportCXF/ExportCXFProcessorTests.swift   | 37 +++++++++++++++++++
 .../ExportCXF/ExportCXFCoordinator.swift      |  1 +
 3 files changed, 50 insertions(+)

diff --git a/BitwardenShared/UI/Tools/ExportCXF/ExportCXF/ExportCXFProcessor.swift b/BitwardenShared/UI/Tools/ExportCXF/ExportCXF/ExportCXFProcessor.swift
index 620baf2c6..d7d470247 100644
--- a/BitwardenShared/UI/Tools/ExportCXF/ExportCXF/ExportCXFProcessor.swift
+++ b/BitwardenShared/UI/Tools/ExportCXF/ExportCXF/ExportCXFProcessor.swift
@@ -11,6 +11,7 @@ class ExportCXFProcessor: StateProcessor<ExportCXFState, ExportCXFAction, Export
     typealias Services = HasConfigService
         & HasErrorReporter
         & HasExportCXFCiphersRepository
+        & HasPolicyService
         & HasStateService
         & HasVaultRepository
 
@@ -70,6 +71,12 @@ class ExportCXFProcessor: StateProcessor<ExportCXFState, ExportCXFAction, Export
     /// Loads the initial data for the view.
     private func load() async {
         do {
+            if await services.policyService.policyAppliesToUser(.disablePersonalVaultExport) {
+                state.status = .failure(message: Localizations.disablePersonalVaultExportPolicyInEffect)
+                state.showMainButton = false
+                return
+            }
+
             let totalItemsToExport = try await services.exportCXFCiphersRepository.getCipherCountToExportCXF()
             guard totalItemsToExport > 0 else {
                 state.status = .failure(message: Localizations.noItems)
@@ -141,6 +148,11 @@ class ExportCXFProcessor: StateProcessor<ExportCXFState, ExportCXFAction, Export
 
     /// Shows the alert confirming the user wants to export items later.
     private func cancelWithConfirmation() {
+        guard state.showMainButton else {
+            coordinator.navigate(to: .dismiss)
+            return
+        }
+
         coordinator.showAlert(.confirmCancelCXFExport { [weak self] in
             guard let self else { return }
             coordinator.navigate(to: .dismiss)
diff --git a/BitwardenShared/UI/Tools/ExportCXF/ExportCXF/ExportCXFProcessorTests.swift b/BitwardenShared/UI/Tools/ExportCXF/ExportCXF/ExportCXFProcessorTests.swift
index a0bf231af..e4d01bbe1 100644
--- a/BitwardenShared/UI/Tools/ExportCXF/ExportCXF/ExportCXFProcessorTests.swift
+++ b/BitwardenShared/UI/Tools/ExportCXF/ExportCXF/ExportCXFProcessorTests.swift
@@ -13,6 +13,7 @@ class ExportCXFProcessorTests: BitwardenTestCase { // swiftlint:disable:this typ
     var delegate: MockExportCXFProcessorDelegate!
     var errorReporter: MockErrorReporter!
     var exportCXFCiphersRepository: MockExportCXFCiphersRepository!
+    var policyService: MockPolicyService!
     var stackNavigator: MockStackNavigator!
     var stateService: MockStateService!
     var subject: ExportCXFProcessor!
@@ -28,6 +29,7 @@ class ExportCXFProcessorTests: BitwardenTestCase { // swiftlint:disable:this typ
         delegate = MockExportCXFProcessorDelegate()
         errorReporter = MockErrorReporter()
         exportCXFCiphersRepository = MockExportCXFCiphersRepository()
+        policyService = MockPolicyService()
         stackNavigator = MockStackNavigator()
         stateService = MockStateService()
         vaultRepository = MockVaultRepository()
@@ -38,6 +40,7 @@ class ExportCXFProcessorTests: BitwardenTestCase { // swiftlint:disable:this typ
                 configService: configService,
                 errorReporter: errorReporter,
                 exportCXFCiphersRepository: exportCXFCiphersRepository,
+                policyService: policyService,
                 stateService: stateService,
                 vaultRepository: vaultRepository
             ),
@@ -53,6 +56,7 @@ class ExportCXFProcessorTests: BitwardenTestCase { // swiftlint:disable:this typ
         delegate = nil
         errorReporter = nil
         exportCXFCiphersRepository = nil
+        policyService = nil
         stackNavigator = nil
         stateService = nil
         subject = nil
@@ -69,6 +73,22 @@ class ExportCXFProcessorTests: BitwardenTestCase { // swiftlint:disable:this typ
         XCTAssertEqual(subject.state.totalItemsToExport, 100)
     }
 
+    /// `perform(_:)` appeared doesn't load the initial data when `.disablePersonalVaultExport`
+    /// applies to user changing the status to failure.
+    @MainActor
+    func test_perform_appearedDisablePersonalVaultExportPolicy() async throws {
+        policyService.policyAppliesToUserResult[.disablePersonalVaultExport] = true
+
+        await subject.perform(.appeared)
+
+        guard case let .failure(message) = subject.state.status else {
+            XCTFail("Status should be failure")
+            return
+        }
+        XCTAssertEqual(message, Localizations.disablePersonalVaultExportPolicyInEffect)
+        XCTAssertFalse(subject.state.showMainButton)
+    }
+
     /// `perform(_:)` appeared loads the initial data but there are zero items
     /// so a failure state is displayed.
     @MainActor
@@ -133,6 +153,23 @@ class ExportCXFProcessorTests: BitwardenTestCase { // swiftlint:disable:this typ
         XCTAssertTrue(coordinator.routes.isEmpty)
     }
 
+    /// `perform(_:)` with `.cancel` when not showing main button navigates to dismiss.
+    @MainActor
+    func test_perform_cancelMainButtonNotShown() async throws {
+        subject.state.showMainButton = false
+        let task = Task {
+            await subject.perform(.cancel)
+        }
+        defer { task.cancel() }
+
+        try await waitForAsync { [weak self] in
+            guard let self else { return true }
+            return !coordinator.routes.isEmpty
+        }
+
+        XCTAssertEqual(.dismiss, coordinator.routes.last)
+    }
+
     /// `perform(_:)` with `.mainButtonTapped` in `.start` status prepares export.
     @MainActor
     func test_perform_mainButtonTappedStartPreparesExport() async throws {
diff --git a/BitwardenShared/UI/Tools/ExportCXF/ExportCXFCoordinator.swift b/BitwardenShared/UI/Tools/ExportCXF/ExportCXFCoordinator.swift
index f127676c1..7a561ad7e 100644
--- a/BitwardenShared/UI/Tools/ExportCXF/ExportCXFCoordinator.swift
+++ b/BitwardenShared/UI/Tools/ExportCXF/ExportCXFCoordinator.swift
@@ -10,6 +10,7 @@ class ExportCXFCoordinator: Coordinator, HasStackNavigator {
     typealias Services = HasConfigService
         & HasErrorReporter
         & HasExportCXFCiphersRepository
+        & HasPolicyService
         & HasStateService
         & HasVaultRepository
 

From 448d184c4e04923799fbedae2e0b3488bcc61d07 Mon Sep 17 00:00:00 2001
From: Federico Maccaroni <fedemkr@gmail.com>
Date: Wed, 15 Jan 2025 13:04:03 -0300
Subject: [PATCH 2/2] PM-15360 Addressed PR feedback simplifying test.

---
 .../ExportCXF/ExportCXF/ExportCXFProcessorTests.swift    | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/BitwardenShared/UI/Tools/ExportCXF/ExportCXF/ExportCXFProcessorTests.swift b/BitwardenShared/UI/Tools/ExportCXF/ExportCXF/ExportCXFProcessorTests.swift
index e4d01bbe1..8c6aa6bdb 100644
--- a/BitwardenShared/UI/Tools/ExportCXF/ExportCXF/ExportCXFProcessorTests.swift
+++ b/BitwardenShared/UI/Tools/ExportCXF/ExportCXF/ExportCXFProcessorTests.swift
@@ -157,15 +157,8 @@ class ExportCXFProcessorTests: BitwardenTestCase { // swiftlint:disable:this typ
     @MainActor
     func test_perform_cancelMainButtonNotShown() async throws {
         subject.state.showMainButton = false
-        let task = Task {
-            await subject.perform(.cancel)
-        }
-        defer { task.cancel() }
 
-        try await waitForAsync { [weak self] in
-            guard let self else { return true }
-            return !coordinator.routes.isEmpty
-        }
+        await subject.perform(.cancel)
 
         XCTAssertEqual(.dismiss, coordinator.routes.last)
     }