Skip to content

Commit 2a00b72

Browse files
authored
Decrease visibility of username generators (#516)
The username generators had excessive visibility and we can make them internal to the crate.
1 parent 68a44bf commit 2a00b72

File tree

7 files changed

+11
-8
lines changed

7 files changed

+11
-8
lines changed

crates/bitwarden-generators/src/username.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ pub enum UsernameGeneratorRequest {
120120
impl ForwarderServiceType {
121121
/// Generate a username using the specified email forwarding service
122122
/// This requires an HTTP client to be passed in, as the service will need to make API calls
123-
pub async fn generate(
123+
async fn generate(
124124
self,
125125
http: &reqwest::Client,
126126
website: Option<String>,

crates/bitwarden-generators/src/username_forwarders/addyio.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ use reqwest::{StatusCode, header::CONTENT_TYPE};
22

33
use crate::username::UsernameError;
44

5-
pub async fn generate(
5+
pub(crate) async fn generate(
66
http: &reqwest::Client,
77
api_token: String,
88
domain: String,

crates/bitwarden-generators/src/username_forwarders/duckduckgo.rs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,10 @@ use reqwest::{StatusCode, header::CONTENT_TYPE};
22

33
use crate::username::UsernameError;
44

5-
pub async fn generate(http: &reqwest::Client, token: String) -> Result<String, UsernameError> {
5+
pub(crate) async fn generate(
6+
http: &reqwest::Client,
7+
token: String,
8+
) -> Result<String, UsernameError> {
69
generate_with_api_url(http, token, "https://quack.duckduckgo.com".into()).await
710
}
811

crates/bitwarden-generators/src/username_forwarders/fastmail.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,15 @@ use serde_json::json;
55

66
use crate::username::UsernameError;
77

8-
pub async fn generate(
8+
pub(crate) async fn generate(
99
http: &reqwest::Client,
1010
api_token: String,
1111
website: Option<String>,
1212
) -> Result<String, UsernameError> {
1313
generate_with_api_url(http, api_token, website, "https://api.fastmail.com".into()).await
1414
}
1515

16-
pub async fn generate_with_api_url(
16+
async fn generate_with_api_url(
1717
http: &reqwest::Client,
1818
api_token: String,
1919
website: Option<String>,

crates/bitwarden-generators/src/username_forwarders/firefox.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ use reqwest::{
55

66
use crate::username::UsernameError;
77

8-
pub async fn generate(
8+
pub(crate) async fn generate(
99
http: &reqwest::Client,
1010
api_token: String,
1111
website: Option<String>,

crates/bitwarden-generators/src/username_forwarders/forwardemail.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ use reqwest::{StatusCode, header::CONTENT_TYPE};
22

33
use crate::username::UsernameError;
44

5-
pub async fn generate(
5+
pub(crate) async fn generate(
66
http: &reqwest::Client,
77
api_token: String,
88
domain: String,

crates/bitwarden-generators/src/username_forwarders/simplelogin.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ use reqwest::{StatusCode, header::CONTENT_TYPE};
22

33
use crate::username::UsernameError;
44

5-
pub async fn generate(
5+
pub(crate) async fn generate(
66
http: &reqwest::Client,
77
api_key: String,
88
base_url: String,

0 commit comments

Comments
 (0)