Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to update to 2024.11.0 self host #308

Closed
DimebagCFH opened this issue Nov 17, 2024 · 19 comments
Closed

Impossible to update to 2024.11.0 self host #308

DimebagCFH opened this issue Nov 17, 2024 · 19 comments

Comments

@DimebagCFH
Copy link

Hello everyone,

I just noticed a new Bitwarden update.
I’ve always used these commands:
./bitwarden.sh updateself
./bitwarden.sh update
Any idea? When trying to update it,
here’s the message I get:
|__ (_) |___ ____ _ _ __ __| | ___ _ __ | '_ \| | __\ \ /\ / / _ | '/ ` |/ _ \ '
| |) | | | \ V V / (| | | | (| | / | | |
|_./||_| _/_/ _,|| _,_|_
|| ||

Open source password management solutions
Copyright 2015-2024, 8bit Solutions LLC
https://bitwarden.com, https://github.com/bitwarden

===================================================

WARNING: This script is running as the root user!
If you are running a standard deployment this script should be running as a dedicated Bitwarden User as per the documentation.
Do you still want to continue? (y/n): y
Continuing....
bitwarden.sh version 2024.11.0
Docker version 20.10.23, build 876964a
docker: 'compose' is not a docker command.
See 'docker --help'
`

@pdk428
Copy link

pdk428 commented Nov 17, 2024

Same issue here

@Jniklas2
Copy link

Just install the docker-compose-plugin package. And remove the deprecated docker-compose from your systems. If you can't find the right package, add the official docker repositories to your sources.

@pdk428
Copy link

pdk428 commented Nov 17, 2024

Just install the docker-compose-plugin package. And remove the deprecated docker-compose from your systems. If you can't find the right package, add the official docker repositories to your sources.

I appreciate you. This did it.

@DimebagCFH
Copy link
Author

DimebagCFH commented Nov 17, 2024

I don't understand why I have to update docker-compose?
I'm running all my applications on a synology, and I don't notice any issue with the other app when I have to update it
How can I proceed to update it on a synology ? (@pdk428 )

@DimebagCFH
Copy link
Author

DimebagCFH commented Nov 18, 2024

It seems that the docker compose version on synology is not running on V2.
Does anyone experience the same issue ?

@Jniklas2
Copy link

Synology is pretty slow, even with important updates... So you need to either wait or find another solution to get the docker compose plugin working

@DimebagCFH
Copy link
Author

That's a pitty

@Jniklas2
Copy link

I've seem some workarounds in other issues and pull requests, but I don't know if and how long they work. Best would be, using a proper vm and install docker and bitwarden inside that vm

@DimebagCFH
Copy link
Author

Someone seems found the solution by editing the run.sh and bitwarden.sh files
bitwarden/server#5043

@Exportedthought
Copy link

Exportedthought commented Nov 19, 2024

I wouldn't call modifying the scripts a solution, just a workaround. At any rate, given the suggestion to install the docker-compose-plugin above I realized that I had installed the docker engine via debian repositories, this seems to have been the root cause. After following the instructions provided direct from docker themselves (and rightfully linked in the bitwarden installation instructions) everything seems to be working as expected. All that said, it does seem likely that it would be a simple fix to just allow the docker-compose syntax and validate which applications are present within the script, since the containers did not have issues prior to this and even during all of my tinkering the containers were running happily in the background, but I certainly could be wrong on this. EDIT: I am most certainly wrong, it seems there was mention of it being deliberately removed in a commit on the 13th due to docker-compose being considered deprecated, I was not aware of that package being deprecated so it looks like the best course of action is to install via official documentation/docker repositories.

@DimebagCFH
Copy link
Author

If i've just well understood your point,
You mean that it's worth to wait for a proper solution, in my case, waiting a fix from Synology and their Container Manager (docker solution provided by Synology)
I prefer to avoid any DIY on the system and experience some wrong side effect

@Exportedthought
Copy link

I am not familiar with synology's docker implementation so I can't comment on that and I'm far from a developer. But generally speaking it's likely not a good idea to make modifications to the scripts, I only did it in a pinch. Also it's worth noting that if you were to modify the scripts you'd need to "re-invent the wheel" each and every time you update since "docker-compose" seems to be deprecated.

@Exportedthought
Copy link

I've seem some workarounds in other issues and pull requests, but I don't know if and how long they work. Best would be, using a proper vm and install docker and bitwarden inside that vm

Personally this seems like the most reasonable option, if running a VM is possible on your hardware that seems to be the most clean of all the options. That way any future modifications/deprecations shouldn't cause any issues since you can bypass the obscurities of whatever synology is doing.

@DimebagCFH
Copy link
Author

Yes, exactly,
This is why, I'm a bit "pissed off" with Synology as we speak.
I choose that solution to avoid any waste of time to configure and setup all my applications needs.
To be honest, this issue is not really blocking, the application is still running, no critical notice regarding any potential security breach or whatever (cfr the release note)

So I can wait for the further actions provided by bitwarden and/or synology environment.

@SergeantConfused
Copy link

Hello everyone,

Thank you all for your input. What is being discussed here is related to the deprecation of Docker Compose V1; The Bitwarden server requires a more recent version of Docker Engine and Docker Compose.

Some of the workarounds mentioned here may assist; However, please remember that the bitwarden.sh script would return to its default syntax after each updateself command, and use docker compose without a hyphen.

As a side note, the workaround shared by @Exportedthought in this GitHub thread could be related to this.

Please feel free to try contacting the vendor of the device/operating system you're using and to see if they'd be able to update their environment.

I will now proceed and close this GitHub report; If you have any questions or concerns, you're more than welcome to get in touch and please include a link to this GitHub report if you do.

Thank you all again,

@SergeantConfused SergeantConfused closed this as not planned Won't fix, can't repro, duplicate, stale Nov 19, 2024
@bglf83
Copy link

bglf83 commented Nov 20, 2024

Yes, exactly, This is why, I'm a bit "pissed off" with Synology as we speak. I choose that solution to avoid any waste of time to configure and setup all my applications needs. To be honest, this issue is not really blocking, the application is still running, no critical notice regarding any potential security breach or whatever (cfr the release note)

So I can wait for the further actions provided by bitwarden and/or synology environment.

I followed the directions from this link to add the docker compose v2 plugin on my synology: https://piotrkrzyzek.com/install-docker-compose-plugin-v2-on-synology-dsm-7/

I used the current version of docker compose v2 (v2.30.3). I assume we will have to re-run this periodically to install the most current release of docker compose. I can confirm my bitwarden updates did work as expected after the update.

DOCKER_CONFIG=${DOCKER_CONFIG:-/usr/local/lib/docker}
mkdir -p $DOCKER_CONFIG/cli-plugins
curl -SL https://github.com/docker/compose/releases/download/v2.30.3/docker-compose-linux-x86_64 -o $DOCKER_CONFIG/cli-plugins/docker-compose
sudo chmod +x /usr/local/lib/docker/cli-plugins/docker-compose

@DimebagCFH
Copy link
Author

@bglf83
Thanks a lot for your help,
Just to be sure, there is no side effect with that plugin I hope
Because I have several docker running on my synology, some of them are managed directly through Portainer (via container manager)

@bglf83
Copy link

bglf83 commented Nov 21, 2024

@bglf83 Thanks a lot for your help, Just to be sure, there is no side effect with that plugin I hope Because I have several docker running on my synology, some of them are managed directly through Portainer (via container manager)

No downfall that I can tell. I also have Portainer. I am not sure if it should be installed as single user or multi-user though. I did multi-user.

@DimebagCFH
Copy link
Author

Thanks again @bglf83
I've tried it, and everything is working well, including my other docker applications, no side effect as we speak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants