Refactor CollectionCipher stored procedures and update index to include Type column

- Updated [CollectionCipher_ReadSharedByOrganizationId] and migration script to select specific columns with brackets for consistency.
- Modified the [IX_Collection_OrganizationId_IncludeAll] index to include the [Type] column for improved query performance.

Author: r-tome

src/Sql/dbo/Stored Procedures/CollectionCipher_ReadSharedByOrganizationId.sql

@@ -5,8 +5,8 @@ BEGIN
     SET NOCOUNT ON
 
     SELECT
-        CC.CollectionId,
-        CC.CipherId
+        CC.[CollectionId],
+        CC.[CipherId]
     FROM
         [dbo].[CollectionCipher] CC
     INNER JOIN

src/Sql/dbo/Tables/Collection.sql

@@ -14,6 +14,6 @@ GO
 
 CREATE NONCLUSTERED INDEX [IX_Collection_OrganizationId_IncludeAll]
     ON [dbo].[Collection]([OrganizationId] ASC)
-    INCLUDE([CreationDate], [Name], [RevisionDate]);
+    INCLUDE([CreationDate], [Name], [RevisionDate], [Type]);
 GO
 

util/Migrator/DbScripts/2025-09-03_00_CollectionCipherManySharedByOrganization.sql

@@ -5,8 +5,8 @@ BEGIN
     SET NOCOUNT ON
 
     SELECT
-        CC.CollectionId,
-        CC.CipherId
+        CC.[CollectionId],
+        CC.[CipherId]
     FROM
         [dbo].[CollectionCipher] CC
     INNER JOIN
@@ -15,3 +15,16 @@ BEGIN
         C.[OrganizationId] = @OrganizationId
         AND C.[Type] = 0 -- SharedCollections only
 END
+GO
+
+-- Update [IX_Collection_OrganizationId_IncludeAll] index to include [Type] column
+IF EXISTS(SELECT name FROM sys.indexes WHERE name = 'IX_Collection_OrganizationId_IncludeAll' AND object_id = OBJECT_ID('[dbo].[Collection]'))
+BEGIN
+    DROP INDEX [IX_Collection_OrganizationId_IncludeAll] ON [dbo].[Collection]
+END
+GO
+
+CREATE NONCLUSTERED INDEX [IX_Collection_OrganizationId_IncludeAll]
+    ON [dbo].[Collection]([OrganizationId] ASC)
+    INCLUDE([CreationDate], [Name], [RevisionDate], [Type])
+GO