Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PM-14489] Limit managed users to confirmed or revoked status #4978

Closed
wants to merge 3 commits into from
Closed

[PM-14489] Limit managed users to confirmed or revoked status #4978

wants to merge 3 commits into from
+224 −7

Conversation

r-tome
Copy link
Contributor

@r-tome r-tome commented Nov 5, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14489

📔 Objective

Managed users currently include users with any status. This is incorrect and could lead to inconsistencies and unexpected behavior. Managed users should only include users with either a "Confirmed" or "Revoked" organization status, as other statuses do not align with intended management operations.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@codecov Codecov
Copy link

codecov bot commented Nov 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@cb7eecc). Learn more about missing BASE report.
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
...zationUserReadByClaimedOrganizationDomainsQuery.cs 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4978   +/-   ##
=======================================
  Coverage        ?   42.54%           
=======================================
  Files           ?     1389           
  Lines           ?    64747           
  Branches        ?     5943           
=======================================
  Hits            ?    27549           
  Misses          ?    35976           
  Partials        ?     1222

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r-tome r-tome marked this pull request as ready for review November 5, 2024 15:34
@r-tome r-tome requested review from a team as code owners November 5, 2024 15:34
@r-tome r-tome requested a review from jrmccannon November 5, 2024 15:34
@r-tome r-tome marked this pull request as draft November 8, 2024 12:36
@r-tome r-tome closed this Nov 8, 2024
@r-tome r-tome deleted the ac/pm-14489/limit-managed-users-to-confirmed-or-revoked-status branch November 22, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrmccannon jrmccannon jrmccannon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r-tome @jrmccannon