[PM-15547] Revoke managed user on 2FA removal if enforced by organization policy #5124
+195
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-tome
commented
Dec 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5124 +/- ##
==========================================
+ Coverage 42.91% 42.96% +0.04%
==========================================
Files 1444 1444
Lines 66086 66101 +15
Branches 6056 6057 +1
==========================================
+ Hits 28358 28397 +39
+ Misses 36446 36422 -24
Partials 1282 1282 ☔ View full report in Codecov by Sentry. |
|
New Issues
Fixed Issues
|
JimmyVo16
reviewed
Dec 10, 2024
JimmyVo16
previously approved these changes
Dec 10, 2024
JimmyVo16
approved these changes
Dec 12, 2024
…ke-managed-user-when-policy-enabled
r-tome
deleted the
ac/pm-15547/disabling-two-factor-should-revoke-managed-user-when-policy-enabled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-15547
📔 Objective
When the two factor organization policy is enabled, then user should be revoked when they remove their 2FA provider if the policy applies to them.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes