Notes 100 - Comment Edit #1196
Open
Notes 100 - Comment Edit #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bldrs-share ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for bldrs-share-v2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
2 tasks
|
Blocked by PR #1167 Unblocked on Friday 05.30 |
OlegMoshkovich
force-pushed
the
Notes-100--Comment-Edit-#1186
branch
from
09db10b
to
702c200
Compare
Signed-off-by: OlegMoshkovich <[email protected]>
…b.com/OlegMoshkovich/Share into Notes-100--Comment-Edit-bldrs-ai#1186
pablo-mayrgundter
requested changes
Jun 4, 2024
| /** Update issue on GH, set read-only */ | ||
| async function submitUpdate() { | ||
| async function updateIssueGithub() { | ||
| const res = await updateIssue(repository, noteNumber, title, editBody, accessToken) | ||
| const editedNote = notes.find((note) => note.id === id) | ||
| editedNote.body = res.data.body |
There was a problem hiding this comment.
this code is related to the issues, i will do it in a separate PR.
Will keep this PR on comments
src/Components/Notes/NoteCard.jsx
Outdated
| * @param {number} commentId | ||
| */ | ||
| async function updateCommentGithub(commentId) { | ||
| const updatedComment = await updateComment(repository, commentId, editBody, accessToken) |
There was a problem hiding this comment.
This is a bit more involved.
It was captured in a separate ticket, so I will take care of it in s separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1186
percy