Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create promisifed methods for methods with callbacks #7

Open
blimmer opened this issue Dec 17, 2017 · 0 comments
Open

Create promisifed methods for methods with callbacks #7

blimmer opened this issue Dec 17, 2017 · 0 comments

Comments

@blimmer
Copy link
Owner

blimmer commented Dec 17, 2017

There are a few methods in the appboy library that take anonymous functions as callbacks:

To better integrate these with Ember, we should expose methods that bind to the Ember run loop and return an RSVP promise. For instance:

// addon/utils/promisified-methods.js

export function rsvpIsPushGranted(safariPushId) {
   ... logic ...
   ... returns a promise ...
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant