-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[idea] small suggestion on "default input.conf" selection #149
Comments
why u think it 'reflect a hierarchy of quality range Highest -> Lowest' ? |
It would be fine to arrange the shaders this way if not for A+A B+B and C+A having severe artifacting issues on about 1/3rd of modern anime. They work exceptionally well when used for specific cases but should not be tried first as they might look good for one scene and not look good for another scene in the same anime. The intended usage is to find the correct mode A, B or C for the anime first, then use the secondary mode if you prefer a higher perceptual quality over accuracy. On a side note, this mess should be gone after I port the newer networks to GLSL. In the future there should be only 2 modes (with restoration and without). An auxiliary style network will encode the global style of the image before passing it to the SRGAN and it will automatically decide how to improve the image and reduce noise. I had very little time to work on porting the new architecture to GLSL (some operations are hard to translate to GLSL without using compute shaders as mpv doesn't support the full compute shader extensions), but it should be out soon... |
judging by a still image, the qualities order as i described are more apparent these are just default sample configurations, or best use. noted i dont only use this scaling and sharpening GLSL for anime. i also use it for live action films, photos, and live streams. its a simple logic of going through each step: if you dont believe there is a "hierarchal quality" sequence then maybe you need to analyse the testing method |
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
no problem
Describe the solution you'd like
A clear and concise description of what you want to happen.
an idea to change the order from A, B, C, A+A, B+B, C+A to
A+A, A, B+B, B, C+A, C
to reflect a hierarchy of quality range Highest -> Lowest
https://github.com/bloc97/Anime4K/blob/master/GLSL_Instructions.md
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
instead of changing, adding a note for alternative input.conf ?
a quick reordering:
numerical reodering:
which your guide is just an example, a template for users to create options with
just an idea. thanks for your work!
The text was updated successfully, but these errors were encountered: