Add support for erc1155 tokens #351
Conversation
| c = ContractWrapper(function_sighashes) | ||
| return c.implements('balanceOf(address,uint256)') and \ | ||
| c.implements('safeTransferFrom(address,address,uint256,uint256,bytes)') and \ | ||
| c.implements('safeBatchTransferFrom(address,address,uint256[],uint256[],bytes') |
There was a problem hiding this comment.
it should be c.implements('safeBatchTransferFrom(address,address,uint256[],uint256[],bytes)')
(Add a ( after the bytes)
I think the part which is relevant to 'token_transfer' also needs to support ERC 1155. |
|
Are you still working on this issue? Also, just out of curiosity, is function like balanceOfBatch not required? |
add erc1155 support, include token_transfer and receipt fix blockchain-etl#351
I'm not. |
|
Hi! Thank you for your contribution. Is there a way this PR to be merged? |
It needs more work. Fixing conflicts and the fixes mentioned above. |
Thank you for reply. Are you going to finish it or I can take it over? |
Take over. I won't be finishing it. |
|
@gekpp Are you working on this issue? |
|
Hi @yongchand . No, unfortunately, i haven't manage to start working on it. |
|
@gekpp @yongchand @elie222 What is the current status of this PR? If nobody is working on it, would it be possible to provide a clear list of what changes remain to get it working? |
|
@leopoldjoy Hey, I have done this on ethereum compatible chain - will try to make PR by end of this week |
|
@yongchand Amazing, thank you! If you need any help to make this happen, please let me know! |
|
@leopoldjoy FYI, just uploaded PR. Let me know if there are additional fixes that I should make. |
Related issue: #315