Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats: add ts type generation for chart ids #1066

Open
bragov4ik opened this issue Sep 25, 2024 · 0 comments
Open

stats: add ts type generation for chart ids #1066

bragov4ik opened this issue Sep 25, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@bragov4ik
Copy link
Contributor

Request from frontend side. Needed for references to particular charts from corresponding widgets (e.g. in verified contracts page). Currently id's are hardcoded, but it's better to have some compile-time check for them in the frontend.

One possible solution - add the id's to *.proto, generate corresponding ts types in pipeline, and verify the id list completeness in rust compile-time (similarly to resolutions, but it will be just an enum type, not something in the actual interface (it could be a good idea to add though?? needs deeper look) ).

@bragov4ik bragov4ik added the enhancement New feature or request label Sep 25, 2024
@bragov4ik bragov4ik self-assigned this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant