Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

env-collector: custom-written "Required" field is overwritten when other env is added #1087

Open
bragov4ik opened this issue Oct 10, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@bragov4ik
Copy link
Contributor

Describe the bug

if you write custom description to "Required" field the variable is checked fine (pass). However, when adding a new env variable, the table update overwrites the custom message

To Reproduce

initial table

| Variable | Req​uir​ed | Description | Default value |
| --- | --- | --- | --- |
| `OVERWRITTEN` | Custom message | | `""` |

Let's say new env NEW_ENV is added.
Generating table should output smth like:

Found missing variables:
  NEW_ENV
Ready to update markdown file: README.md
Press any key to continue...

All variables are documented

Observed behavior

Should be smth like

| Variable | Req​uir​ed | Description | Default value |
| --- | --- | --- | --- |
| `OVERWRITTEN` | | | `""` |
| `NEW_ENV` | | | `""` |

Expected behavior

| Variable | Req​uir​ed | Description | Default value |
| --- | --- | --- | --- |
| `OVERWRITTEN` | Custom message  | | `""` |
| `NEW_ENV` | | | `""` |

Additional context

I observed it in stats service; env STATS__BLOCKSCOUT_API_URL; but made up the simple example for this issue (that I didn't check) but it should work.

@bragov4ik bragov4ik added the bug Something isn't working label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant