Skip to content

Commit

Permalink
Fix some warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
AntonioND committed Mar 11, 2023
1 parent c0d9040 commit d5ea7e9
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 5 deletions.
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ SOURCES_CPP := $(shell find -L $(SOURCEDIRS) -name "*.cpp")
# Compiler and linker flags
# -------------------------

WARNFLAGS_C := -Wall -Wno-multichar -Wno-unused-but-set-variable \
-Wno-unused-variable -Wno-unused-result
WARNFLAGS_C := -Wall -Wextra -Wno-multichar -Wno-unused-but-set-variable \
-Wno-unused-result -Wno-sign-compare -Wno-type-limits

WARNFLAGS_CXX := -Wall

Expand Down
3 changes: 1 addition & 2 deletions source/msl.c
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ void MSL_Erase( void )
u16 MSL_AddSample( Sample* samp )
{
u32 sample_length;
u32 x;
file_open_write_end( TMP_SAMP );

sample_length = samp->sample_length;
Expand Down Expand Up @@ -393,4 +392,4 @@ int MSL_Create( char* argv[], int argc, char* output, char* header, bool verbose
file_delete( TMP_SAMP );
file_delete( TMP_SONG );
return ERR_NONE;
}
}
4 changes: 3 additions & 1 deletion source/s3m.c
Original file line number Diff line number Diff line change
Expand Up @@ -269,8 +269,10 @@ int Load_S3M( MAS_Module* mod, bool verbose )
for( x = 0; x < 28; x++ )
mod->title[x] = read8(); // read song name

if( read8() != 0x1A );
read8(); // No need to check this value
// if( read8() != 0x1A )
// return ERR_INVALID_MODULE;

if( read8() != 16 )
return ERR_INVALID_MODULE;
if( verbose )
Expand Down
1 change: 1 addition & 0 deletions source/upload.c
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,6 @@

void Upload_GBA( char* filename )
{
(void)filename;
// todo.........
}

0 comments on commit d5ea7e9

Please sign in to comment.