Skip to content

Commit

Permalink
Internal doc bit.
Browse files Browse the repository at this point in the history
  • Loading branch information
bluescarni committed Aug 10, 2024
1 parent 767ecd4 commit 8b52b94
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions src/expression_cfunc.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2247,6 +2247,16 @@ make_multi_cfunc(const llvm_state &tplt, const std::string &name, const std::vec
spdlog::stopwatch sw;

// Build the compiled functions.
//
// NOTE: in order to further parallelise the creation of the individual functions, we should:
//
// - do a first pass analyzing the decomposition in order to decide where to initiate
// the construction of the drivers,
// - construct the drivers in parallel, perhaps pushing back the states as they are constructed
// into a thread-safe tbb vector.
//
// At the moment though it looks like the practical gains from such further parallelisation
// would not be worth it, perhaps we can reconsider in the future.
if (batch_size == 1u) {
oneapi::tbb::parallel_invoke([&create_cfunc]() { create_cfunc(false, 1); },
[&create_cfunc]() { create_cfunc(true, 1); });
Expand Down

0 comments on commit 8b52b94

Please sign in to comment.