Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Fixes #66

Closed
3 tasks done
Paxxack opened this issue Oct 29, 2024 · 3 comments · Fixed by #98
Closed
3 tasks done

General Fixes #66

Paxxack opened this issue Oct 29, 2024 · 3 comments · Fixed by #98
Assignees
Labels
Bug Something isn't working Frontend Frontend Related Issue
Milestone

Comments

@Paxxack
Copy link
Collaborator

Paxxack commented Oct 29, 2024

  • Button ripple effect need to be removed ( Global Theme).
  • The app background color scheme need to be adjusted as shown on the Figma. (White backgrounds)
  • We need to add a box shadow to the popup menus across the app.
@Paxxack Paxxack added the Bug Something isn't working label Oct 29, 2024
@mahid797 mahid797 self-assigned this Oct 29, 2024
@mahid797
Copy link
Contributor

mahid797 commented Nov 1, 2024

@Paxxack
Regarding adding the box shadows to popup menus, need some clarification. It seems most of the menus already have shadows applied. Are there specific menus that lack shadows, or is the goal to unify the shadow style across all menus? Right now, the shadows for different menus differ in the Figma design.

Currently, the menus we have include:

  • Sidebar Dropdown Menu
  • Dropdown Selects
  • Action Menu (in the Document Page table)

@gorkem-bwl
Copy link
Contributor

As far as I remember, it was the action menu of the main dashboard table if I am not mistaken. If we can unify the shadow style across all menus, that would be great. There may be some inconsistencies in the Figma design, and you can ignore them - coming up with your own menu shadow template to provide a consistent look and feel.

@mahid797
Copy link
Contributor

mahid797 commented Nov 7, 2024

Shadow Inconsistency will be addressed as part of Issue #65, along with other changes related to the GlobalTheme.

@mahid797 mahid797 added the Frontend Frontend Related Issue label Nov 7, 2024
Paxxack added a commit that referenced this issue Nov 11, 2024
@mahid797 mahid797 linked a pull request Nov 12, 2024 that will close this issue
@mahid797 mahid797 added this to the 1.0 milestone Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Frontend Frontend Related Issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants