Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar item should be highlighted when I am inside a page #409

Open
gorkem-bwl opened this issue Dec 21, 2024 · 9 comments
Open

Sidebar item should be highlighted when I am inside a page #409

gorkem-bwl opened this issue Dec 21, 2024 · 9 comments
Assignees
Labels
bug Something isn't working frontend Frontend task/issue good-first-issue

Comments

@gorkem-bwl
Copy link
Contributor

When I click on a sidebar item, that area should be highlighted for a visual cue. Highlight color can be the same as the hover color.

image
@gorkem-bwl gorkem-bwl added bug Something isn't working frontend Frontend task/issue good-first-issue labels Dec 21, 2024
@Tushnik1
Copy link

Tushnik1 commented Dec 21, 2024

Hi, @gorkem-bwl . I noticed this issue and worked on the solution. I would be happy to submit a PR request for review if that's okay.

@Tushnik1
Copy link

Screenshot 2024-12-21 210427

Solved the issue of highlighting the selected menu option, it will look like this.

@gorkem-bwl
Copy link
Contributor Author

Solved the issue of highlighting the selected menu option, it will look like this.

Is this the same color as the hover color?

@Tushnik1
Copy link

Tushnik1 commented Dec 21, 2024

Yes, and i did darken the letters for more highlighting

@Tushnik1
Copy link

Shall I proceed to make a PR request?

@bolatein
Copy link
Contributor

bolatein commented Dec 21, 2024

@Tushnik1 Please only change the background color of the selected menu item (to the same color while hovering). Keep the others (letter formating etc.) as they are.

See the reference image below.

Screenshot 2024-12-21 at 23 00 30

@Tushnik1
Copy link

Okk, I did the required changes. 👍
Screenshot 2024-12-22 014439

Please let me know if it is okk or something is required to be changed.

@bolatein
Copy link
Contributor

@Tushnik1 Thanks for your contribution. We decided to proceed with some other design development. So, I'll assign this to the internal team.

@Tushnik1
Copy link

@bolatein Okk

@erenfn erenfn removed their assignment Dec 23, 2024
@erenfn erenfn assigned bolatein and MandeepPaul and unassigned bolatein Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Frontend task/issue good-first-issue
Projects
None yet
Development

No branches or pull requests

5 participants