Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bug in neo_pyclone_annotation.py #5

Open
songofbin opened this issue May 18, 2020 · 1 comment
Open

A bug in neo_pyclone_annotation.py #5

songofbin opened this issue May 18, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@songofbin
Copy link

Some positive pMHC are missing in my pTuneos results. I think that's because of a bug in the 119 line of the neo_pyclone_annotation.py script. People should change it:

from
data_drop=data_fill_na.drop_duplicates(subset=["Gene","MT_pep","WT_pep"])
to
data_drop=data_fill_na.drop_duplicates(subset=["HLA_type","Gene","MT_pep","WT_pep"])

@ChiZhou-SITI
Copy link
Contributor

Yes, if you want to get pMHC pairs from the results, HLA type should also be taken into consideration when drop duplicates.
We will fix it later.
Thank you for your suggestion!

@ChiZhou-SITI ChiZhou-SITI added the bug Something isn't working label Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants