Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is IPMI internal? #254

Open
omar-m-othman opened this issue Dec 30, 2021 · 1 comment
Open

Why is IPMI internal? #254

omar-m-othman opened this issue Dec 30, 2021 · 1 comment

Comments

@omar-m-othman
Copy link
Contributor

After understanding internal packages in Go, I now know why we have to have such a code in Actor. My question is: Why?

The code in Actor is now inconsistent, and it will definitely remain so.
@joelrebel
Copy link
Member

joelrebel commented Jan 20, 2022 •
edited
Loading

The IPMI implementation in Actor was done before bmclib got its implemention of the IPMI interface methods. What is your point in this issue, do you have a suggestion for a way forward?

This is also Actor specific, if you'd like bmclib to expose certain IPMI methods, then create an issue for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joelrebel @omar-m-othman