Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid propagating loose ranges from resolutions during autofix #398

Open
bmish opened this issue Mar 27, 2022 · 0 comments
Open

Avoid propagating loose ranges from resolutions during autofix #398

bmish opened this issue Mar 27, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@bmish
Copy link
Owner

bmish commented Mar 27, 2022

In resolutions, it's more common to use > or >= ranges to ensure a dependency is above a particular (especially vulnerable) version.

Example:

package.json:

{
  "workspaces": ["*"],
  "resolutions": {
    "foo": ">= 5"
  }
}

package1/package.json:

{
  "dependencies": {
    "foo": "^4.0.0"
  }
}

The autofix will currently change foo's version to >= 5, which is likely unsafe/overly-aggressive.

Related: #348

@bmish bmish added the bug Something isn't working label Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant