Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 prysm dependencies in go.mod with different version. #2553

Closed
zzzckck opened this issue Jun 28, 2024 · 1 comment
Closed

2 prysm dependencies in go.mod with different version. #2553

zzzckck opened this issue Jun 28, 2024 · 1 comment
Assignees

Comments

@zzzckck
Copy link
Collaborator

zzzckck commented Jun 28, 2024

Description

we may have another issue: 2 prysm dependencies in go.mod with different version.

➜  bsc git:(03f9326f1) cat go.mod|grep "prysm"
	github.com/prysmaticlabs/prysm/v5 v5.0.3
	github.com/prysmaticlabs/prysm v0.0.0-20220124113610-e26cde5e091b // indirect
0.20210702154020-550e1cd83ec1

v5.0.3: was for BSC BLS related
v0.0.0-20220124113610-e26cde5e091b: was imported indirectly for GreenField precompile contract.

➜  bsc git:(03f9326f1) go mod why -m github.com/prysmaticlabs/prysm
# github.com/prysmaticlabs/prysm
github.com/ethereum/go-ethereum/core/vm/lightclient/v2
github.com/cometbft/cometbft/light
github.com/cometbft/cometbft/light/provider/http
github.com/cometbft/cometbft/rpc/client
github.com/cometbft/cometbft/rpc/core/types
github.com/cometbft/cometbft/votepool
github.com/prysmaticlabs/prysm/crypto/bls/blst
➜  bsc git:(03f9326f1) go mod why -m github.com/prysmaticlabs/prysm/v5
# github.com/prysmaticlabs/prysm/v5
github.com/ethereum/go-ethereum/cmd/geth
github.com/prysmaticlabs/prysm/v5/crypto/bls

it would be better if we can unified the dependency of prysm.

@keefel
Copy link
Contributor

keefel commented Jul 3, 2024

Fixed in #2556

@zzzckck zzzckck closed this as completed Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants