Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails due to mismatch in tablet configuration #24

Open
nahn20 opened this issue Sep 30, 2023 · 0 comments · May be fixed by #33
Open

Build fails due to mismatch in tablet configuration #24

nahn20 opened this issue Sep 30, 2023 · 0 comments · May be fixed by #33

Comments

@nahn20
Copy link
Contributor

nahn20 commented Sep 30, 2023

Detection

EAS build failing due to error: The UIDeviceFamily of an App Clip ('[1]') must be equal to the UIDeviceFamily of its containing parent app ('[1, 2]').. After manually building and viewing in Xcode, the main app target supports iPhone, iPad, and Mac while the app clip supports only iPhone and Mac.

Minimum Reproducible Example

Temporary Fix

Remove tablet support from the main app (supportsTablet: false). For obvious reasons, not an ideal fix. I'm sure one could better fix this by manually adding tablet support in the app clip's Info.plist.

Suggested Fix

Conditionally add iPad as a supported destination based on the value of supportsTablet.

@RobertSasak RobertSasak linked a pull request Mar 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant